Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: Source/modules/webmidi/MIDIOutput.h

Issue 24070002: Web MIDI: MIDIInput/MIDIOutput should not have reference to MIDIAccess (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: (rebase) Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/modules/webmidi/MIDIInput.idl ('k') | Source/modules/webmidi/MIDIOutput.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 static PassRefPtr<MIDIOutput> create(MIDIAccess*, unsigned portIndex, Script ExecutionContext*, const String& id, const String& manufacturer, const String& n ame, const String& version); 46 static PassRefPtr<MIDIOutput> create(MIDIAccess*, unsigned portIndex, Script ExecutionContext*, const String& id, const String& manufacturer, const String& n ame, const String& version);
47 virtual ~MIDIOutput(); 47 virtual ~MIDIOutput();
48 48
49 void send(Uint8Array*, double timestamp, ExceptionState&); 49 void send(Uint8Array*, double timestamp, ExceptionState&);
50 void send(Vector<unsigned>, double timestamp, ExceptionState&); 50 void send(Vector<unsigned>, double timestamp, ExceptionState&);
51 51
52 // send() without optional |timestamp|. 52 // send() without optional |timestamp|.
53 void send(Uint8Array*, ExceptionState&); 53 void send(Uint8Array*, ExceptionState&);
54 void send(Vector<unsigned>, ExceptionState&); 54 void send(Vector<unsigned>, ExceptionState&);
55 55
56 MIDIAccess* midiAccess() const { return m_access; }
57
56 private: 58 private:
57 MIDIOutput(MIDIAccess*, unsigned portIndex, ScriptExecutionContext*, const S tring& id, const String& manufacturer, const String& name, const String& version ); 59 MIDIOutput(MIDIAccess*, unsigned portIndex, ScriptExecutionContext*, const S tring& id, const String& manufacturer, const String& name, const String& version );
58 60
59 RefPtr<MIDIAccess> m_access; 61 MIDIAccess* m_access;
60 unsigned m_portIndex; 62 unsigned m_portIndex;
61 }; 63 };
62 64
63 typedef Vector<RefPtr<MIDIOutput> > MIDIOutputVector; 65 typedef Vector<RefPtr<MIDIOutput> > MIDIOutputVector;
64 66
65 } // namespace WebCore 67 } // namespace WebCore
66 68
67 #endif // MIDIOutput_h 69 #endif // MIDIOutput_h
OLDNEW
« no previous file with comments | « Source/modules/webmidi/MIDIInput.idl ('k') | Source/modules/webmidi/MIDIOutput.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698