Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: Source/modules/webmidi/MIDIOutput.cpp

Issue 24070002: Web MIDI: MIDIInput/MIDIOutput should not have reference to MIDIAccess (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: (rebase) Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/modules/webmidi/MIDIOutput.h ('k') | Source/modules/webmidi/MIDIOutput.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 21 matching lines...) Expand all
32 #include "modules/webmidi/MIDIOutput.h" 32 #include "modules/webmidi/MIDIOutput.h"
33 33
34 #include "bindings/v8/ExceptionState.h" 34 #include "bindings/v8/ExceptionState.h"
35 #include "core/dom/ExceptionCode.h" 35 #include "core/dom/ExceptionCode.h"
36 #include "modules/webmidi/MIDIAccess.h" 36 #include "modules/webmidi/MIDIAccess.h"
37 37
38 namespace WebCore { 38 namespace WebCore {
39 39
40 PassRefPtr<MIDIOutput> MIDIOutput::create(MIDIAccess* access, unsigned portIndex , ScriptExecutionContext* context, const String& id, const String& manufacturer, const String& name, const String& version) 40 PassRefPtr<MIDIOutput> MIDIOutput::create(MIDIAccess* access, unsigned portIndex , ScriptExecutionContext* context, const String& id, const String& manufacturer, const String& name, const String& version)
41 { 41 {
42 ASSERT(access);
42 return adoptRef(new MIDIOutput(access, portIndex, context, id, manufacturer, name, version)); 43 return adoptRef(new MIDIOutput(access, portIndex, context, id, manufacturer, name, version));
43 } 44 }
44 45
45 MIDIOutput::MIDIOutput(MIDIAccess* access, unsigned portIndex, ScriptExecutionCo ntext* context, const String& id, const String& manufacturer, const String& name , const String& version) 46 MIDIOutput::MIDIOutput(MIDIAccess* access, unsigned portIndex, ScriptExecutionCo ntext* context, const String& id, const String& manufacturer, const String& name , const String& version)
46 : MIDIPort(context, id, manufacturer, name, MIDIPortTypeOutput, version) 47 : MIDIPort(context, id, manufacturer, name, MIDIPortTypeOutput, version)
47 , m_access(access) 48 , m_access(access)
48 , m_portIndex(portIndex) 49 , m_portIndex(portIndex)
49 { 50 {
50 ScriptWrappable::init(this); 51 ScriptWrappable::init(this);
51 } 52 }
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 { 93 {
93 send(data, 0, es); 94 send(data, 0, es);
94 } 95 }
95 96
96 void MIDIOutput::send(Vector<unsigned> unsignedData, ExceptionState& es) 97 void MIDIOutput::send(Vector<unsigned> unsignedData, ExceptionState& es)
97 { 98 {
98 send(unsignedData, 0, es); 99 send(unsignedData, 0, es);
99 } 100 }
100 101
101 } // namespace WebCore 102 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/modules/webmidi/MIDIOutput.h ('k') | Source/modules/webmidi/MIDIOutput.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698