Makes sure that an input method doesn't reference to a destroyed object.

Makes sure that an input method doesn't reference to a destroyed object.

This CL makes sure that an input method never reference to a destroyed object.  We're not 100% sure why Issue 280219 is happening, but it seems a destroyed object is referenced from an input method.

For render_widget_host_view_win.cc, there is no need to check the focus.  Even if it's not focused, the object going to be destroyed should be removed from the TSFBridge.

BUG=280219
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221302

[Yuki, 2013-09-04 09:08:53]

Could you review this CL?

[Yohei Yukawa, 2013-09-04 09:22:59]

lgtm

[Seigo Nonaka, 2013-09-04 10:19:21]

lgtm

lgtm with nits

Please confirm this work with following scenario:

1. Focus in/out from/to other window.
2. Close focused second window.
3. Pop up and close of pop-up window like menu, omnibox suggest.

Thank you.

https://codereview.chromium.org/23478020/diff/1/ui/base/ime/input_method.h
File ui/base/ime/input_method.h (right):

https://codereview.chromium.org/23478020/diff/1/ui/base/ime/input_method.h#ne...
ui/base/ime/input_method.h:90: // not.  This method is meant to be called when
the |client| is going to be
nit: /  / /

https://codereview.chromium.org/23478020/diff/1/ui/base/ime/mock_input_method.cc
File ui/base/ime/mock_input_method.cc (right):

https://codereview.chromium.org/23478020/diff/1/ui/base/ime/mock_input_method...
ui/base/ime/mock_input_method.cc:28: if (text_input_client_ == client) {
nit: no need braces for one liner.

[Yuki, 2013-09-04 14:01:51]

https://codereview.chromium.org/23478020/diff/1/ui/base/ime/input_method.h
File ui/base/ime/input_method.h (right):

https://codereview.chromium.org/23478020/diff/1/ui/base/ime/input_method.h#ne...
ui/base/ime/input_method.h:90: // not.  This method is meant to be called when
the |client| is going to be
On 2013/09/04 10:19:21, Seigo Nonaka wrote:
> nit: /  / /

Talked offline, and it seems okay to have two successive spaces between
sentences.

https://codereview.chromium.org/23478020/diff/1/ui/base/ime/mock_input_method.cc
File ui/base/ime/mock_input_method.cc (right):

https://codereview.chromium.org/23478020/diff/1/ui/base/ime/mock_input_method...
ui/base/ime/mock_input_method.cc:28: if (text_input_client_ == client) {
On 2013/09/04 10:19:21, Seigo Nonaka wrote:
> nit: no need braces for one liner.

Done.

[Yuki, 2013-09-04 14:04:13]

Sky, could you review this CL as an owner of content/browser/ ?

[sky, 2013-09-04 16:26:52]

How about some test coverage?

[sky, 2013-09-04 16:27:36]

I'm LGTMing now, but would like test coverage.

[Yuki, 2013-09-04 16:55:38]

Thanks for the review.  I'd like to fix the issue very soon, so let me commit
this CL.
I'll send another CL to test this change tomorrow.

[commit-bot: I haz the power, 2013-09-04 16:56:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yukishiino@chromium.org/23478020/6001

[commit-bot: I haz the power, 2013-09-04 23:47:38]

Change committed as 221302