Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Side by Side Diff: ui/base/ime/input_method_base.h

Issue 23478020: Makes sure that an input method doesn't reference to a destroyed object. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Worked on nits. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/base/ime/input_method.h ('k') | ui/base/ime/input_method_base.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_BASE_IME_INPUT_METHOD_BASE_H_ 5 #ifndef UI_BASE_IME_INPUT_METHOD_BASE_H_
6 #define UI_BASE_IME_INPUT_METHOD_BASE_H_ 6 #define UI_BASE_IME_INPUT_METHOD_BASE_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/observer_list.h" 10 #include "base/observer_list.h"
(...skipping 19 matching lines...) Expand all
30 30
31 // Overriden from InputMethod. 31 // Overriden from InputMethod.
32 virtual void SetDelegate(internal::InputMethodDelegate* delegate) OVERRIDE; 32 virtual void SetDelegate(internal::InputMethodDelegate* delegate) OVERRIDE;
33 virtual void Init(bool focused) OVERRIDE; 33 virtual void Init(bool focused) OVERRIDE;
34 // If a derived class overrides OnFocus()/OnBlur(), it should call parent's 34 // If a derived class overrides OnFocus()/OnBlur(), it should call parent's
35 // implementation first, to make sure |system_toplevel_window_focused_| flag 35 // implementation first, to make sure |system_toplevel_window_focused_| flag
36 // can be updated correctly. 36 // can be updated correctly.
37 virtual void OnFocus() OVERRIDE; 37 virtual void OnFocus() OVERRIDE;
38 virtual void OnBlur() OVERRIDE; 38 virtual void OnBlur() OVERRIDE;
39 virtual void SetFocusedTextInputClient(TextInputClient* client) OVERRIDE; 39 virtual void SetFocusedTextInputClient(TextInputClient* client) OVERRIDE;
40 virtual void DetachTextInputClient(TextInputClient* client) OVERRIDE;
40 virtual TextInputClient* GetTextInputClient() const OVERRIDE; 41 virtual TextInputClient* GetTextInputClient() const OVERRIDE;
41 42
42 // If a derived class overrides this method, it should call parent's 43 // If a derived class overrides this method, it should call parent's
43 // implementation. 44 // implementation.
44 virtual void OnTextInputTypeChanged(const TextInputClient* client) OVERRIDE; 45 virtual void OnTextInputTypeChanged(const TextInputClient* client) OVERRIDE;
45 46
46 virtual TextInputType GetTextInputType() const OVERRIDE; 47 virtual TextInputType GetTextInputType() const OVERRIDE;
47 virtual TextInputMode GetTextInputMode() const OVERRIDE; 48 virtual TextInputMode GetTextInputMode() const OVERRIDE;
48 virtual bool CanComposeInline() const OVERRIDE; 49 virtual bool CanComposeInline() const OVERRIDE;
49 50
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 ObserverList<InputMethodObserver> observer_list_; 94 ObserverList<InputMethodObserver> observer_list_;
94 95
95 bool system_toplevel_window_focused_; 96 bool system_toplevel_window_focused_;
96 97
97 DISALLOW_COPY_AND_ASSIGN(InputMethodBase); 98 DISALLOW_COPY_AND_ASSIGN(InputMethodBase);
98 }; 99 };
99 100
100 } // namespace ui 101 } // namespace ui
101 102
102 #endif // UI_BASE_IME_INPUT_METHOD_BASE_H_ 103 #endif // UI_BASE_IME_INPUT_METHOD_BASE_H_
OLDNEW
« no previous file with comments | « ui/base/ime/input_method.h ('k') | ui/base/ime/input_method_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698