ui/base/ime/dummy_input_method.h - Issue 23478020: Makes sure that an input method doesn't reference to a destroyed object.

Side by Side Diff: ui/base/ime/dummy_input_method.h

Issue 23478020: Makes sure that an input method doesn't reference to a destroyed object. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Worked on nits. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_win.cc ('k') | ui/base/ime/dummy_input_method.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef UI_BASE_IME_DUMMY_INPUT_METHOD_H_	5 #ifndef UI_BASE_IME_DUMMY_INPUT_METHOD_H_

6 #define UI_BASE_IME_DUMMY_INPUT_METHOD_H_	6 #define UI_BASE_IME_DUMMY_INPUT_METHOD_H_

7	7

8 #include "ui/base/ime/input_method.h"	8 #include "ui/base/ime/input_method.h"

9	9

10 namespace ui {	10 namespace ui {

11	11

12 class InputMethodObserver;	12 class InputMethodObserver;

13	13

14 class DummyInputMethod : public InputMethod {	14 class DummyInputMethod : public InputMethod {

15 public:	15 public:

16 DummyInputMethod();	16 DummyInputMethod();

17 virtual ~DummyInputMethod();	17 virtual ~DummyInputMethod();

18	18

19 // InputMethod overrides:	19 // InputMethod overrides:

20 virtual void SetDelegate(	20 virtual void SetDelegate(

21 internal::InputMethodDelegate* delegate) OVERRIDE;	21 internal::InputMethodDelegate* delegate) OVERRIDE;

22 virtual void Init(bool focused) OVERRIDE;	22 virtual void Init(bool focused) OVERRIDE;

23 virtual void OnFocus() OVERRIDE;	23 virtual void OnFocus() OVERRIDE;

24 virtual void OnBlur() OVERRIDE;	24 virtual void OnBlur() OVERRIDE;

25 virtual bool OnUntranslatedIMEMessage(	25 virtual bool OnUntranslatedIMEMessage(

26 const base::NativeEvent& event, NativeEventResult* result) OVERRIDE;	26 const base::NativeEvent& event, NativeEventResult* result) OVERRIDE;

27 virtual void SetFocusedTextInputClient(TextInputClient* client) OVERRIDE;	27 virtual void SetFocusedTextInputClient(TextInputClient* client) OVERRIDE;

	28 virtual void DetachTextInputClient(TextInputClient* client) OVERRIDE;

28 virtual TextInputClient* GetTextInputClient() const OVERRIDE;	29 virtual TextInputClient* GetTextInputClient() const OVERRIDE;

29 virtual bool DispatchKeyEvent(const base::NativeEvent& event) OVERRIDE;	30 virtual bool DispatchKeyEvent(const base::NativeEvent& event) OVERRIDE;

30 virtual bool DispatchFabricatedKeyEvent(const ui::KeyEvent& event) OVERRIDE;	31 virtual bool DispatchFabricatedKeyEvent(const ui::KeyEvent& event) OVERRIDE;

31 virtual void OnTextInputTypeChanged(const TextInputClient* client) OVERRIDE;	32 virtual void OnTextInputTypeChanged(const TextInputClient* client) OVERRIDE;

32 virtual void OnCaretBoundsChanged(const TextInputClient* client) OVERRIDE;	33 virtual void OnCaretBoundsChanged(const TextInputClient* client) OVERRIDE;

33 virtual void CancelComposition(const TextInputClient* client) OVERRIDE;	34 virtual void CancelComposition(const TextInputClient* client) OVERRIDE;

34 virtual void OnInputLocaleChanged() OVERRIDE;	35 virtual void OnInputLocaleChanged() OVERRIDE;

35 virtual std::string GetInputLocale() OVERRIDE;	36 virtual std::string GetInputLocale() OVERRIDE;

36 virtual base::i18n::TextDirection GetInputTextDirection() OVERRIDE;	37 virtual base::i18n::TextDirection GetInputTextDirection() OVERRIDE;

37 virtual bool IsActive() OVERRIDE;	38 virtual bool IsActive() OVERRIDE;

38 virtual TextInputType GetTextInputType() const OVERRIDE;	39 virtual TextInputType GetTextInputType() const OVERRIDE;

39 virtual TextInputMode GetTextInputMode() const OVERRIDE;	40 virtual TextInputMode GetTextInputMode() const OVERRIDE;

40 virtual bool CanComposeInline() const OVERRIDE;	41 virtual bool CanComposeInline() const OVERRIDE;

41 virtual bool IsCandidatePopupOpen() const OVERRIDE;	42 virtual bool IsCandidatePopupOpen() const OVERRIDE;

42 virtual void AddObserver(InputMethodObserver* observer) OVERRIDE;	43 virtual void AddObserver(InputMethodObserver* observer) OVERRIDE;

43 virtual void RemoveObserver(InputMethodObserver* observer) OVERRIDE;	44 virtual void RemoveObserver(InputMethodObserver* observer) OVERRIDE;

44	45

45 private:	46 private:

46 DISALLOW_COPY_AND_ASSIGN(DummyInputMethod);	47 DISALLOW_COPY_AND_ASSIGN(DummyInputMethod);

47 };	48 };

48	49

49 } // namespace ui	50 } // namespace ui

50	51

51 #endif // UI_BASE_IME_DUMMY_INPUT_METHOD_H_	52 #endif // UI_BASE_IME_DUMMY_INPUT_METHOD_H_

52	53

OLD	NEW