ui/base/ime/input_method_base.h - Issue 23478020: Makes sure that an input method doesn't reference to a destroyed object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/ime/input_method_base.h

Issue 23478020: Makes sure that an input method doesn't reference to a destroyed object. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Worked on nits. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/ime/input_method_base.h

diff --git a/ui/base/ime/input_method_base.h b/ui/base/ime/input_method_base.h

index 655fd4abf0af15e0de816d8ab6689ed79ea1816a..a3a106e83992c31eab776f981633786efaa7aa97 100644

--- a/ui/base/ime/input_method_base.h

+++ b/ui/base/ime/input_method_base.h

@@ -37,6 +37,7 @@ class UI_EXPORT InputMethodBase : NON_EXPORTED_BASE(public InputMethod) {

virtual void OnFocus() OVERRIDE;

virtual void OnBlur() OVERRIDE;

virtual void SetFocusedTextInputClient(TextInputClient* client) OVERRIDE;

+ virtual void DetachTextInputClient(TextInputClient* client) OVERRIDE;

virtual TextInputClient* GetTextInputClient() const OVERRIDE;

// If a derived class overrides this method, it should call parent's

« no previous file with comments | « ui/base/ime/input_method.h ('k') | ui/base/ime/input_method_base.cc » ('j') | no next file with comments »