Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Side by Side Diff: ui/base/ime/fake_input_method.h

Issue 23478020: Makes sure that an input method doesn't reference to a destroyed object. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Worked on nits. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/base/ime/dummy_input_method.cc ('k') | ui/base/ime/fake_input_method.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_BASE_IME_FAKE_INPUT_METHOD_H_ 5 #ifndef UI_BASE_IME_FAKE_INPUT_METHOD_H_
6 #define UI_BASE_IME_FAKE_INPUT_METHOD_H_ 6 #define UI_BASE_IME_FAKE_INPUT_METHOD_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 16 matching lines...) Expand all
27 virtual ~FakeInputMethod(); 27 virtual ~FakeInputMethod();
28 28
29 // Overriden from InputMethod. 29 // Overriden from InputMethod.
30 virtual void SetDelegate(internal::InputMethodDelegate* delegate) OVERRIDE; 30 virtual void SetDelegate(internal::InputMethodDelegate* delegate) OVERRIDE;
31 virtual void Init(bool focused) OVERRIDE; 31 virtual void Init(bool focused) OVERRIDE;
32 virtual void OnFocus() OVERRIDE; 32 virtual void OnFocus() OVERRIDE;
33 virtual void OnBlur() OVERRIDE; 33 virtual void OnBlur() OVERRIDE;
34 virtual bool OnUntranslatedIMEMessage(const base::NativeEvent& event, 34 virtual bool OnUntranslatedIMEMessage(const base::NativeEvent& event,
35 NativeEventResult* result) OVERRIDE; 35 NativeEventResult* result) OVERRIDE;
36 virtual void SetFocusedTextInputClient(TextInputClient* client) OVERRIDE; 36 virtual void SetFocusedTextInputClient(TextInputClient* client) OVERRIDE;
37 virtual void DetachTextInputClient(TextInputClient* client) OVERRIDE;
37 virtual TextInputClient* GetTextInputClient() const OVERRIDE; 38 virtual TextInputClient* GetTextInputClient() const OVERRIDE;
38 virtual bool DispatchKeyEvent(const base::NativeEvent& native_event) OVERRIDE; 39 virtual bool DispatchKeyEvent(const base::NativeEvent& native_event) OVERRIDE;
39 virtual bool DispatchFabricatedKeyEvent(const ui::KeyEvent& event) OVERRIDE; 40 virtual bool DispatchFabricatedKeyEvent(const ui::KeyEvent& event) OVERRIDE;
40 virtual void OnTextInputTypeChanged(const TextInputClient* client) OVERRIDE; 41 virtual void OnTextInputTypeChanged(const TextInputClient* client) OVERRIDE;
41 virtual void OnCaretBoundsChanged(const TextInputClient* client) OVERRIDE; 42 virtual void OnCaretBoundsChanged(const TextInputClient* client) OVERRIDE;
42 virtual void CancelComposition(const TextInputClient* client) OVERRIDE; 43 virtual void CancelComposition(const TextInputClient* client) OVERRIDE;
43 virtual void OnInputLocaleChanged() OVERRIDE; 44 virtual void OnInputLocaleChanged() OVERRIDE;
44 virtual std::string GetInputLocale() OVERRIDE; 45 virtual std::string GetInputLocale() OVERRIDE;
45 virtual base::i18n::TextDirection GetInputTextDirection() OVERRIDE; 46 virtual base::i18n::TextDirection GetInputTextDirection() OVERRIDE;
46 virtual bool IsActive() OVERRIDE; 47 virtual bool IsActive() OVERRIDE;
47 virtual TextInputType GetTextInputType() const OVERRIDE; 48 virtual TextInputType GetTextInputType() const OVERRIDE;
48 virtual TextInputMode GetTextInputMode() const OVERRIDE; 49 virtual TextInputMode GetTextInputMode() const OVERRIDE;
49 virtual bool CanComposeInline() const OVERRIDE; 50 virtual bool CanComposeInline() const OVERRIDE;
50 virtual bool IsCandidatePopupOpen() const OVERRIDE; 51 virtual bool IsCandidatePopupOpen() const OVERRIDE;
51 virtual void AddObserver(InputMethodObserver* observer) OVERRIDE; 52 virtual void AddObserver(InputMethodObserver* observer) OVERRIDE;
52 virtual void RemoveObserver(InputMethodObserver* observer) OVERRIDE; 53 virtual void RemoveObserver(InputMethodObserver* observer) OVERRIDE;
53 54
54 private: 55 private:
55 internal::InputMethodDelegate* delegate_; 56 internal::InputMethodDelegate* delegate_;
56 TextInputClient* text_input_client_; 57 TextInputClient* text_input_client_;
57 ObserverList<InputMethodObserver> observers_; 58 ObserverList<InputMethodObserver> observers_;
58 59
59 DISALLOW_COPY_AND_ASSIGN(FakeInputMethod); 60 DISALLOW_COPY_AND_ASSIGN(FakeInputMethod);
60 }; 61 };
61 62
62 } // namespace ui 63 } // namespace ui
63 64
64 #endif // UI_BASE_IME_FAKE_INPUT_METHOD_H_ 65 #endif // UI_BASE_IME_FAKE_INPUT_METHOD_H_
OLDNEW
« no previous file with comments | « ui/base/ime/dummy_input_method.cc ('k') | ui/base/ime/fake_input_method.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698