Issue 23021021: Set the GPU info using the crash key system instead of platform-specific mechanisms.

Issue 23021021: Set the GPU info using the crash key system instead of platform-specific mechanisms. (Closed)

Created:
7 years, 3 months ago by Robert Sesek

Modified:
7 years, 3 months ago

Reviewers:
Lei Zhang, Zhenyao Mo

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Set the GPU info using the crash key system instead of platform-specific mechanisms. BUG=77656 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219855

Patch Set 2 : Fix Linux compile #

Patch Set 4 : Address comments #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -183 lines)			Patch
M	chrome/app/breakpad_linux.cc	View	1	2 chunks	+0 lines, -37 lines	0 comments	Download
M	chrome/app/breakpad_win.cc	View		3 chunks	+0 lines, -38 lines	0 comments	Download
M	chrome/common/child_process_logging.h	View		3 chunks	+0 lines, -14 lines	0 comments	Download
M	chrome/common/child_process_logging_mac.mm	View		3 chunks	+0 lines, -38 lines	0 comments	Download
M	chrome/common/child_process_logging_posix.cc	View	1 2 3	3 chunks	+0 lines, -28 lines	0 comments	Download
M	chrome/common/child_process_logging_win.cc	View	1 2 3	3 chunks	+0 lines, -27 lines	0 comments	Download
M	chrome/common/chrome_content_client.cc	View	1 2	2 chunks	+19 lines, -1 line	0 comments	Download
M	chrome/common/crash_keys.h	View	1 2 3	1 chunk	+15 lines, -0 lines	0 comments	Download
M	chrome/common/crash_keys.cc	View	1 2 3	2 chunks	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

lgtm zmo: Care to take a look in case I missed anything? https://codereview.chromium.org/23021021/diff/16001/chrome/common/child_process_logging_posix.cc File chrome/common/child_process_logging_posix.cc ...

7 years, 3 months ago (2013-08-26 21:41:01 UTC) #2

Robert Sesek

https://codereview.chromium.org/23021021/diff/16001/chrome/common/child_process_logging_posix.cc File chrome/common/child_process_logging_posix.cc (right): https://codereview.chromium.org/23021021/diff/16001/chrome/common/child_process_logging_posix.cc#newcode15 chrome/common/child_process_logging_posix.cc:15: #include "url/gurl.h" On 2013/08/26 21:41:01, Lei Zhang wrote: > ...

7 years, 3 months ago (2013-08-27 15:34:52 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/23021021/29001

7 years, 3 months ago (2013-08-27 15:40:56 UTC) #5

Message was sent while issue was closed.

Change committed as 219855

Expand Messages | Collapse Messages