Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2365)

Unified Diff: chrome/common/child_process_logging_win.cc

Issue 23021021: Set the GPU info using the crash key system instead of platform-specific mechanisms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/child_process_logging_posix.cc ('k') | chrome/common/chrome_content_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/child_process_logging_win.cc
diff --git a/chrome/common/child_process_logging_win.cc b/chrome/common/child_process_logging_win.cc
index 8e6c9b50bb41e07475028a776df2d54264dd4ce3..d64b66fd4f2c7f5c990aeb5e8d06184f390a593c 100644
--- a/chrome/common/child_process_logging_win.cc
+++ b/chrome/common/child_process_logging_win.cc
@@ -9,13 +9,11 @@
#include "base/command_line.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
-#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/common/chrome_constants.h"
#include "chrome/common/crash_keys.h"
#include "chrome/common/metrics/variations/variations_util.h"
#include "chrome/installer/util/google_update_settings.h"
-#include "gpu/config/gpu_info.h"
namespace child_process_logging {
@@ -32,11 +30,6 @@ typedef void (__cdecl *MainSetNumberOfExtensions)(int);
// void __declspec(dllexport) __cdecl SetExtensionID.
typedef void (__cdecl *MainSetExtensionID)(size_t, const wchar_t*);
-// exported in breakpad_win.cc: void __declspec(dllexport) __cdecl SetGpuInfo.
-typedef void (__cdecl *MainSetGpuInfo)(const wchar_t*, const wchar_t*,
- const wchar_t*, const wchar_t*,
- const wchar_t*);
-
// exported in breakpad_win.cc:
// void __declspec(dllexport) __cdecl SetPrinterInfo.
typedef void (__cdecl *MainSetPrinterInfo)(const wchar_t*);
@@ -147,26 +140,6 @@ void SetActiveExtensions(const std::set<std::string>& extension_ids) {
}
}
-void SetGpuInfo(const gpu::GPUInfo& gpu_info) {
- static MainSetGpuInfo set_gpu_info = NULL;
- // note: benign race condition on set_gpu_info.
- if (!set_gpu_info) {
- HMODULE exe_module = GetModuleHandle(chrome::kBrowserProcessExecutableName);
- if (!exe_module)
- return;
- set_gpu_info = reinterpret_cast<MainSetGpuInfo>(
- GetProcAddress(exe_module, "SetGpuInfo"));
- if (!set_gpu_info)
- return;
- }
- (set_gpu_info)(
- base::StringPrintf(L"0x%04x", gpu_info.gpu.vendor_id).c_str(),
- base::StringPrintf(L"0x%04x", gpu_info.gpu.device_id).c_str(),
- UTF8ToUTF16(gpu_info.driver_version).c_str(),
- UTF8ToUTF16(gpu_info.pixel_shader_version).c_str(),
- UTF8ToUTF16(gpu_info.vertex_shader_version).c_str());
-}
-
void SetPrinterInfo(const char* printer_info) {
static MainSetPrinterInfo set_printer_info = NULL;
// note: benign race condition on set_printer_info.
« no previous file with comments | « chrome/common/child_process_logging_posix.cc ('k') | chrome/common/chrome_content_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698