Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: chrome/common/crash_keys.cc

Issue 23021021: Set the GPU info using the crash key system instead of platform-specific mechanisms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/crash_keys.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/crash_keys.cc
diff --git a/chrome/common/crash_keys.cc b/chrome/common/crash_keys.cc
index eae240320c05e5d83b1b9f928afe5fb457cfcebe..31539791ae5a6e75c73a85f15ffbd510675663c1 100644
--- a/chrome/common/crash_keys.cc
+++ b/chrome/common/crash_keys.cc
@@ -46,6 +46,19 @@ COMPILE_ASSERT(kMediumSize <= kSingleChunkLength,
size_t RegisterChromeCrashKeys() {
base::debug::CrashKey keys[] = {
{ kActiveURL, kLargeSize },
+#if !defined(OS_ANDROID)
+ { kGPUVendorID, kSmallSize },
+ { kGPUDeviceID, kSmallSize },
+#endif
+ { kGPUDriverVersion, kSmallSize },
+ { kGPUPixelShaderVersion, kSmallSize },
+ { kGPUVertexShaderVersion, kSmallSize },
+#if defined(OS_LINUX)
+ { kGPUVendor, kSmallSize },
+ { kGPURenderer, kSmallSize },
+#elif defined(OS_MACOSX)
+ { kGPUGLVersion, kSmallSize },
+#endif
// content/:
{ "ppapi_path", kMediumSize },
@@ -74,6 +87,20 @@ size_t RegisterChromeCrashKeys() {
const char kActiveURL[] = "url-chunk";
+#if !defined(OS_ANDROID)
+const char kGPUVendorID[] = "gpu-venid";
+const char kGPUDeviceID[] = "gpu-devid";
+#endif
+const char kGPUDriverVersion[] = "gpu-driver";
+const char kGPUPixelShaderVersion[] = "gpu-psver";
+const char kGPUVertexShaderVersion[] = "gpu-vsver";
+#if defined(OS_LINUX)
+const char kGPUVendor[] = "gpu-gl-vendor";
+const char kGPURenderer[] = "gpu-gl-renderer";
+#elif defined(OS_MACOSX)
+const char kGPUGLVersion[] = "gpu-glver";
+#endif
+
#if defined(OS_MACOSX)
namespace mac {
« no previous file with comments | « chrome/common/crash_keys.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698