Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4726)

Unified Diff: chrome/common/child_process_logging_mac.mm

Issue 23021021: Set the GPU info using the crash key system instead of platform-specific mechanisms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/child_process_logging.h ('k') | chrome/common/child_process_logging_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/child_process_logging_mac.mm
diff --git a/chrome/common/child_process_logging_mac.mm b/chrome/common/child_process_logging_mac.mm
index da7c7fe1bd3660fd901de4ec491ce0bb95f22146..50cbfdaa819369e8efcfc540210ad6fa725730eb 100644
--- a/chrome/common/child_process_logging_mac.mm
+++ b/chrome/common/child_process_logging_mac.mm
@@ -15,7 +15,6 @@
#include "base/strings/utf_string_conversions.h"
#include "chrome/common/metrics/variations/variations_util.h"
#include "chrome/installer/util/google_update_settings.h"
-#include "gpu/config/gpu_info.h"
namespace child_process_logging {
@@ -25,12 +24,6 @@ using base::debug::SetCrashKeyValue;
using base::debug::ClearCrashKey;
const char* kGuidParamName = "guid";
-const char* kGPUVendorIdParamName = "gpu-venid";
-const char* kGPUDeviceIdParamName = "gpu-devid";
-const char* kGPUDriverVersionParamName = "gpu-driver";
-const char* kGPUPixelShaderVersionParamName = "gpu-psver";
-const char* kGPUVertexShaderVersionParamName = "gpu-vsver";
-const char* kGPUGLVersionParamName = "gpu-glver";
const char* kNumberOfViews = "num-views";
const char* kNumExtensionsName = "num-extensions";
const char* kExtensionNameFormat = "extension-%zu";
@@ -79,37 +72,6 @@ void SetActiveExtensions(const std::set<std::string>& extension_ids) {
}
}
-void SetGpuKeyValue(const char* param_name, const std::string& value_str,
- SetCrashKeyValueFuncT set_key_func) {
- set_key_func(param_name, value_str);
-}
-
-void SetGpuInfoImpl(const gpu::GPUInfo& gpu_info,
- SetCrashKeyValueFuncT set_key_func) {
- SetGpuKeyValue(kGPUVendorIdParamName,
- base::StringPrintf("0x%04x", gpu_info.gpu.vendor_id),
- set_key_func);
- SetGpuKeyValue(kGPUDeviceIdParamName,
- base::StringPrintf("0x%04x", gpu_info.gpu.device_id),
- set_key_func);
- SetGpuKeyValue(kGPUDriverVersionParamName,
- gpu_info.driver_version,
- set_key_func);
- SetGpuKeyValue(kGPUPixelShaderVersionParamName,
- gpu_info.pixel_shader_version,
- set_key_func);
- SetGpuKeyValue(kGPUVertexShaderVersionParamName,
- gpu_info.vertex_shader_version,
- set_key_func);
- SetGpuKeyValue(kGPUGLVersionParamName,
- gpu_info.gl_version,
- set_key_func);
-}
-
-void SetGpuInfo(const gpu::GPUInfo& gpu_info) {
- SetGpuInfoImpl(gpu_info, SetCrashKeyValue);
-}
-
void SetPrinterInfo(const char* printer_info) {
std::vector<std::string> info;
base::SplitString(printer_info, ';', &info);
« no previous file with comments | « chrome/common/child_process_logging.h ('k') | chrome/common/child_process_logging_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698