Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 22929034: Relocate and refactor overview mode files. (Closed)

Created:
7 years, 4 months ago by flackr
Modified:
7 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Relocate and refactor overview mode files. BUG=None TEST=ash_unittests pass. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219165

Patch Set 1 #

Patch Set 2 : Add class comment. #

Total comments: 4

Patch Set 3 : Adjust similarity and address comments. #

Total comments: 2

Patch Set 4 : Remove extra newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -1712 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash.gyp View 1 2 4 chunks +8 lines, -6 lines 0 comments Download
M ash/shell.cc View 2 chunks +1 line, -1 line 0 comments Download
A + ash/wm/overview/window_selector.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/overview/window_selector.cc View 1 2 4 chunks +12 lines, -277 lines 0 comments Download
A + ash/wm/overview/window_selector_controller.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + ash/wm/overview/window_selector_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ash/wm/overview/window_selector_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/wm/overview/window_selector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A ash/wm/overview/window_selector_window.h View 1 2 1 chunk +84 lines, -0 lines 0 comments Download
A + ash/wm/overview/window_selector_window.cc View 1 2 3 5 chunks +4 lines, -315 lines 0 comments Download
D ash/wm/window_selector.h View 1 chunk +0 lines, -120 lines 0 comments Download
D ash/wm/window_selector.cc View 1 chunk +0 lines, -550 lines 0 comments Download
D ash/wm/window_selector_controller.h View 1 chunk +0 lines, -72 lines 0 comments Download
D ash/wm/window_selector_controller.cc View 1 chunk +0 lines, -122 lines 0 comments Download
D ash/wm/window_selector_delegate.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ash/wm/window_selector_unittest.cc View 1 chunk +0 lines, -202 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
flackr
derat suggested I move WindowSelectorWindow into a separate file and all of the overview files ...
7 years, 4 months ago (2013-08-22 16:07:35 UTC) #1
sky
This is just copying right? Can you play with the --similarity so it shows up ...
7 years, 4 months ago (2013-08-22 17:01:14 UTC) #2
flackr
Yes, this is just copying and separating a class into its own files. Adjusted the ...
7 years, 4 months ago (2013-08-22 17:21:23 UTC) #3
sky
LGTM https://codereview.chromium.org/22929034/diff/8001/ash/wm/overview/window_selector_window.cc File ash/wm/overview/window_selector_window.cc (right): https://codereview.chromium.org/22929034/diff/8001/ash/wm/overview/window_selector_window.cc#newcode1 ash/wm/overview/window_selector_window.cc:1: nit: remove newline.
7 years, 4 months ago (2013-08-22 20:18:22 UTC) #4
flackr
https://codereview.chromium.org/22929034/diff/8001/ash/wm/overview/window_selector_window.cc File ash/wm/overview/window_selector_window.cc (right): https://codereview.chromium.org/22929034/diff/8001/ash/wm/overview/window_selector_window.cc#newcode1 ash/wm/overview/window_selector_window.cc:1: On 2013/08/22 20:18:22, sky wrote: > nit: remove newline. ...
7 years, 4 months ago (2013-08-22 21:09:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/22929034/12001
7 years, 4 months ago (2013-08-22 21:24:15 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-23 00:39:40 UTC) #7
Message was sent while issue was closed.
Change committed as 219165

Powered by Google App Engine
This is Rietveld 408576698