Rename extension_manifest_keys namespace to extensions::manifest_keys.

Rename extension_manifest_keys namespace to extensions::manifest_keys.

Move it to extensions/common/manifest_constants.cc.

Minorly improve packaged app + manifest version 1 error message.

BUG=162530
TBR=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217709

[Yoyo Zhou, 2013-08-14 21:11:03]

https://codereview.chromium.org/22794012/diff/2001/chrome/common/extensions/e...
File chrome/common/extensions/extension.cc (right):

https://codereview.chromium.org/22794012/diff/2001/chrome/common/extensions/e...
chrome/common/extensions/extension.cc:755: if (manifest_version_ <
kModernManifestVersion &&
This (and manifest.cc) is the only functional change.

[Matt Perry, 2013-08-14 21:18:37]

lgtm

[Yoyo Zhou, 2013-08-14 21:35:22]

TBR'ing ben for uninteresting refactoring

[commit-bot: I haz the power, 2013-08-14 21:36:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/22794012/2001

[commit-bot: I haz the power, 2013-08-14 21:37:29]

Failed to apply patch for chrome/browser/extensions/convert_web_app.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/convert_web_app.cc
  Hunk #2 FAILED at 57.
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/extensions/convert_web_app.cc.rej

Patch:       chrome/browser/extensions/convert_web_app.cc
Index: chrome/browser/extensions/convert_web_app.cc
diff --git a/chrome/browser/extensions/convert_web_app.cc
b/chrome/browser/extensions/convert_web_app.cc
index
5f844aba93fe6c56cdd8cd5d67cb59b7d42a5836..38685e7cb17d4b89004c8155c9de64e0cc9d8b49
100644
--- a/chrome/browser/extensions/convert_web_app.cc
+++ b/chrome/browser/extensions/convert_web_app.cc
@@ -22,17 +22,17 @@
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_file_util.h"
-#include "chrome/common/extensions/extension_manifest_constants.h"
 #include "chrome/common/web_application_info.h"
 #include "crypto/sha2.h"
 #include "extensions/common/constants.h"
+#include "extensions/common/manifest_constants.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/codec/png_codec.h"
 #include "url/gurl.h"
 
 namespace extensions {
 
-namespace keys = extension_manifest_keys;
+namespace keys = manifest_keys;
 
 using base::Time;
 
@@ -57,8 +57,7 @@ std::string GenerateKey(const GURL& manifest_url) {
   return key;
 }
 
-}
-
+}  // namespace
 
 // Generates a version for the converted app using the current date. This isn't
 // really needed, but it seems like useful information.

[commit-bot: I haz the power, 2013-08-14 22:09:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/22794012/10001

[commit-bot: I haz the power, 2013-08-15 00:36:33]

Change committed as 217709