chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc - Issue 22794012: Rename extension_manifest_keys namespace to extensions::manifest_keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

Issue 22794012: Rename extension_manifest_keys namespace to extensions::manifest_keys. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

index 3d361b0ceb0e8c9b0567063e5b24028453813225..b4e5f678650df32e3a26171c41c482c8dbd1c30b 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

@@ -11,6 +11,7 @@

#include "chrome/common/extensions/incognito_handler.h"

#include "chrome/common/extensions/manifest_handlers/app_isolation_info.h"

#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

+#include "extensions/common/error_utils.h"

#include "extensions/common/switches.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -36,9 +37,10 @@ TEST_F(PlatformAppsManifestTest, PlatformApps) {

Testcase error_testcases[] = {

Testcase("init_invalid_platform_app_2.json",

- errors::kBackgroundRequiredForPlatformApps),

+ errors::kBackgroundRequiredForPlatformApps),

Testcase("init_invalid_platform_app_3.json",

- errors::kPlatformAppNeedsManifestVersion2),

+ ErrorUtils::FormatErrorMessage(

+ errors::kInvalidManifestVersionOld, "2", "apps")),

};

RunTestcases(error_testcases, arraysize(error_testcases), EXPECT_TYPE_ERROR);