chrome/common/extensions/manifest_handlers/externally_connectable.cc - Issue 22794012: Rename extension_manifest_keys namespace to extensions::manifest_keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/externally_connectable.cc

Issue 22794012: Rename extension_manifest_keys namespace to extensions::manifest_keys. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/content_scripts_handler.cc ('k') | chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/externally_connectable.cc

diff --git a/chrome/common/extensions/manifest_handlers/externally_connectable.cc b/chrome/common/extensions/manifest_handlers/externally_connectable.cc

index 60f928c318bd21f4768c248403c90c5997a8b60a..2a6e3093f1a0223c0a8dea150233c1df6572051a 100644

--- a/chrome/common/extensions/manifest_handlers/externally_connectable.cc

+++ b/chrome/common/extensions/manifest_handlers/externally_connectable.cc

@@ -9,10 +9,10 @@

#include "base/stl_util.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/common/extensions/api/manifest_types.h"

-#include "chrome/common/extensions/extension_manifest_constants.h"

#include "chrome/common/extensions/permissions/api_permission_set.h"

#include "chrome/common/extensions/permissions/permissions_data.h"

#include "extensions/common/error_utils.h"

+#include "extensions/common/manifest_constants.h"

#include "extensions/common/url_pattern.h"

#include "net/base/registry_controlled_domains/registry_controlled_domain.h"

#include "url/gurl.h"

@@ -35,7 +35,7 @@ const char kErrorWildcardHostsNotAllowed[] =

"Wildcard domain patterns such as \"*\" are not allowed";

} // namespace externally_connectable_errors

-namespace keys = extension_manifest_keys;

+namespace keys = extensions::manifest_keys;

namespace errors = externally_connectable_errors;

using api::manifest_types::ExternallyConnectable;