Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: chrome/common/extensions/api/extension_api_unittest.cc

Issue 22794012: Rename extension_manifest_keys namespace to extensions::manifest_keys. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/extension_api_unittest.cc
diff --git a/chrome/common/extensions/api/extension_api_unittest.cc b/chrome/common/extensions/api/extension_api_unittest.cc
index dc94433823600d4c9dadb306ce834dd35ae4746d..9433df2d5ccb29169364bf8167fd6048c7fa4a9d 100644
--- a/chrome/common/extensions/api/extension_api_unittest.cc
+++ b/chrome/common/extensions/api/extension_api_unittest.cc
@@ -19,13 +19,13 @@
#include "chrome/common/chrome_paths.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_builder.h"
-#include "chrome/common/extensions/extension_manifest_constants.h"
#include "chrome/common/extensions/extension_test_util.h"
#include "chrome/common/extensions/features/api_feature.h"
#include "chrome/common/extensions/features/base_feature_provider.h"
#include "chrome/common/extensions/features/simple_feature.h"
#include "chrome/common/extensions/manifest.h"
#include "chrome/common/extensions/value_builder.h"
+#include "extensions/common/manifest_constants.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace extensions {
@@ -468,10 +468,10 @@ TEST(ExtensionAPITest, ExtensionWithUnprivilegedAPIs) {
scoped_refptr<Extension> CreateHostedApp() {
base::DictionaryValue values;
- values.SetString(extension_manifest_keys::kName, "test");
- values.SetString(extension_manifest_keys::kVersion, "0.1");
- values.Set(extension_manifest_keys::kWebURLs, new base::ListValue());
- values.SetString(extension_manifest_keys::kLaunchWebURL,
+ values.SetString(manifest_keys::kName, "test");
+ values.SetString(manifest_keys::kVersion, "0.1");
+ values.Set(manifest_keys::kWebURLs, new base::ListValue());
+ values.SetString(manifest_keys::kLaunchWebURL,
"http://www.example.com");
std::string error;
scoped_refptr<Extension> extension(Extension::Create(
@@ -484,9 +484,9 @@ scoped_refptr<Extension> CreateHostedApp() {
scoped_refptr<Extension> CreatePackagedAppWithPermissions(
const std::set<std::string>& permissions) {
base::DictionaryValue values;
- values.SetString(extension_manifest_keys::kName, "test");
- values.SetString(extension_manifest_keys::kVersion, "0.1");
- values.SetString(extension_manifest_keys::kPlatformAppBackground,
+ values.SetString(manifest_keys::kName, "test");
+ values.SetString(manifest_keys::kVersion, "0.1");
+ values.SetString(manifest_keys::kPlatformAppBackground,
"http://www.example.com");
base::DictionaryValue* app = new base::DictionaryValue();
@@ -495,7 +495,7 @@ scoped_refptr<Extension> CreatePackagedAppWithPermissions(
scripts->Append(new base::StringValue("test.js"));
background->Set("scripts", scripts);
app->Set("background", background);
- values.Set(extension_manifest_keys::kApp, app);
+ values.Set(manifest_keys::kApp, app);
{
scoped_ptr<base::ListValue> permissions_list(new base::ListValue());
for (std::set<std::string>::const_iterator i = permissions.begin();

Powered by Google App Engine
This is Rietveld 408576698