Add a feature to display a persistence toggle for permission prompts on Android.

Add a feature to display a persistence toggle for permission prompts on Android.

This CL adds a disabled by default feature which shows a "Remember my
decision" toggle on permission prompts on Android. This is designed to
test whether a more explicit representation of permission persistence
(and better control over it) will encourage users to make decisions on
these prompts more often. It is intended to experiment with this
feature from M54.

A new PermissionInfoBar class is added to implement the optional
toggle. Permission-specific code in ConfirmInfoBar is moved into the
new class, which will also be beneficial in the future if permission
prompts stop being infobars. The permission decision is changed
from a boolean allowed/not allowed to the PermissionAction enum
already used for permission metrics reporting.

New metrics to measure the toggle position of prompts which are
granted or denied are also added in this CL to measure whether or
not users actually interact with the toggle (or if merely seeing it
is sufficient to change the wider permission action metrics).

The toggle is explicitly disabled for all permissions except
geolocation, which currently generates the most prompts on Android.

A subsequent CL will implement a corresponding checkbox for
desktop permission prompts using the same feature. The desktop
permission decision will also be changed to a PermissionAction.

BUG=632269
Committed: https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd
Cr-Commit-Position: refs/heads/master@{#412177}

[dominickn, 2016-08-08 07:53:53]

dominickn@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[dominickn, 2016-08-08 07:53:54]

WDYT? I tried to implement this in the least intrusive way possible. I haven't
fully tested everything yet, and haven't hooked up the permissions side of it
yet - I wanted to get feedback on how the infobar side looks. Thanks!

[gone, 2016-08-08 23:04:02]

https://chromiumcodereview.appspot.com/2226633002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java
(right):

https://chromiumcodereview.appspot.com/2226633002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java:86:
private void setShowPersistenceToggle(boolean showPersistenceToggle) {
Yeah, you shouldn't put this here.  It's a specific control for a specific
infobar.  You should subclass ConfirmInfoBar.java/confirm_infobar.cc and move
this stuff into it.  PermissionInfoBar and PermissionInfoBarDelegate would then
handle the special-cased logic you're trying to do.

[dominickn, 2016-08-09 03:40:17]

On 2016/08/08 23:04:02, dfalcantara wrote:
>
https://chromiumcodereview.appspot.com/2226633002/diff/1/chrome/android/java/...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java
> (right):
> 
>
https://chromiumcodereview.appspot.com/2226633002/diff/1/chrome/android/java/...
>
chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java:86:
> private void setShowPersistenceToggle(boolean showPersistenceToggle) {
> Yeah, you shouldn't put this here.  It's a specific control for a specific
> infobar.  You should subclass ConfirmInfoBar.java/confirm_infobar.cc and move
> this stuff into it.  PermissionInfoBar and PermissionInfoBarDelegate would
then
> handle the special-cased logic you're trying to do.

Acknowledged. What about the content settings stuff in ConfirmInfoBar? I think
it's only used for permissions infobars, but it's cluttering ConfirmInfoBar. I'd
prefer to not to move that around right now, particularly since we're thinking
of moving to a modal prompt in the future.

[dominickn, 2016-08-09 03:53:09]

On 2016/08/09 03:40:17, dominickn wrote:
> On 2016/08/08 23:04:02, dfalcantara wrote:
> >
>
https://chromiumcodereview.appspot.com/2226633002/diff/1/chrome/android/java/...
> > File
> >
>
chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java
> > (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/2226633002/diff/1/chrome/android/java/...
> >
>
chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java:86:
> > private void setShowPersistenceToggle(boolean showPersistenceToggle) {
> > Yeah, you shouldn't put this here.  It's a specific control for a specific
> > infobar.  You should subclass ConfirmInfoBar.java/confirm_infobar.cc and
move
> > this stuff into it.  PermissionInfoBar and PermissionInfoBarDelegate would
> then
> > handle the special-cased logic you're trying to do.
> 
> Acknowledged. What about the content settings stuff in ConfirmInfoBar? I think
> it's only used for permissions infobars, but it's cluttering ConfirmInfoBar.
I'd
> prefer to not to move that around right now, particularly since we're thinking
> of moving to a modal prompt in the future.

Now that I think about it, moving that stuff out isn't that complicated, and it
will help if we stop using infobars for permissions on Android. :)

[gone, 2016-08-09 06:47:52]

On 2016/08/09 03:53:09, dominickn wrote:
> On 2016/08/09 03:40:17, dominickn wrote:
> > On 2016/08/08 23:04:02, dfalcantara wrote:
> > >
> >
>
https://chromiumcodereview.appspot.com/2226633002/diff/1/chrome/android/java/...
> > > File
> > >
> >
>
chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java
> > > (right):
> > > 
> > >
> >
>
https://chromiumcodereview.appspot.com/2226633002/diff/1/chrome/android/java/...
> > >
> >
>
chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java:86:
> > > private void setShowPersistenceToggle(boolean showPersistenceToggle) {
> > > Yeah, you shouldn't put this here.  It's a specific control for a specific
> > > infobar.  You should subclass ConfirmInfoBar.java/confirm_infobar.cc and
> move
> > > this stuff into it.  PermissionInfoBar and PermissionInfoBarDelegate would
> > then
> > > handle the special-cased logic you're trying to do.
> > 
> > Acknowledged. What about the content settings stuff in ConfirmInfoBar? I
think
> > it's only used for permissions infobars, but it's cluttering ConfirmInfoBar.
> I'd
> > prefer to not to move that around right now, particularly since we're
thinking
> > of moving to a modal prompt in the future.
> 
> Now that I think about it, moving that stuff out isn't that complicated, and
it
> will help if we stop using infobars for permissions on Android. :)

Yeah... I think that was put there as a last ditch effort to meet some absurdly
short Android
deadline for revocable permission prompts.  It was eventually meant to be moved
elsewhere,
but if it ain't broke...

If you think it's not too bad to move, go for it.

[dominickn, 2016-08-09 07:06:39]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 07:07:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2016-08-09 07:12:39]

Description was changed from

==========
Add a feature which displays a "Remember my decision" toggle for permission
prompts.

This CL adds hooks into ConfirmInfoBar to display a "Remember my
decision" toggle on permission prompts. This is designed to test whether
a more explicit representation of permission persistence (and better
control over it) will encourage users to make decisions on these prompts
more often.

BUG=632269
==========

to

==========
Add a feature which displays a "Remember my decision" toggle for permission
prompts.

This CL adds a disabled by default feature which shows a "Remember my
decision" toggle on permission prompts on Android. This is designed to
test whether a more explicit representation of permission persistence
(and better control over it) will encourage users to make decisions on
these prompts more often. It is intended to experiment with this
feature from M54.

A new PermissionInfoBar class is added to implement the optional
toggle. Permission-specific code in ConfirmInfoBar is moved into the
new class, which will also be beneficial in the future if permission
prompts stop being infobars. The permission decision is changed
from a boolean allowed/not allowed to the PermissionAction enum
already used for permission metrics reporting.

A subsequent CL will implement a corresponding checkbox for
desktop permission prompts using the same feature. The desktop
permission decision will also be changed to a PermissionAction.

BUG=632269
==========

[dominickn, 2016-08-09 07:43:06]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 07:43:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2016-08-09 08:09:05]

Description was changed from

==========
Add a feature which displays a "Remember my decision" toggle for permission
prompts.

This CL adds a disabled by default feature which shows a "Remember my
decision" toggle on permission prompts on Android. This is designed to
test whether a more explicit representation of permission persistence
(and better control over it) will encourage users to make decisions on
these prompts more often. It is intended to experiment with this
feature from M54.

A new PermissionInfoBar class is added to implement the optional
toggle. Permission-specific code in ConfirmInfoBar is moved into the
new class, which will also be beneficial in the future if permission
prompts stop being infobars. The permission decision is changed
from a boolean allowed/not allowed to the PermissionAction enum
already used for permission metrics reporting.

A subsequent CL will implement a corresponding checkbox for
desktop permission prompts using the same feature. The desktop
permission decision will also be changed to a PermissionAction.

BUG=632269
==========

to

==========
Add a feature which displays a "Remember my decision" toggle for permission
prompts.

This CL adds a disabled by default feature which shows a "Remember my
decision" toggle on permission prompts on Android. This is designed to
test whether a more explicit representation of permission persistence
(and better control over it) will encourage users to make decisions on
these prompts more often. It is intended to experiment with this
feature from M54.

A new PermissionInfoBar class is added to implement the optional
toggle. Permission-specific code in ConfirmInfoBar is moved into the
new class, which will also be beneficial in the future if permission
prompts stop being infobars. The permission decision is changed
from a boolean allowed/not allowed to the PermissionAction enum
already used for permission metrics reporting.

New metrics to measure the toggle position of prompts which are
granted or denied are also added in this CL to measure whether or
not users actually interact with the toggle (or if merely seeing it
is sufficient to change the wider permission action metrics).

A subsequent CL will implement a corresponding checkbox for
desktop permission prompts using the same feature. The desktop
permission decision will also be changed to a PermissionAction.

BUG=632269
==========

[dominickn, 2016-08-09 08:16:38]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[dominickn, 2016-08-09 08:16:47]

PTAL - now factored out into a new PermissionInfoBar and wired through to the
permissions layer. I moved the permissions-centric code out of ConfirmInfoBar
entirely. WDYT?

[commit-bot: I haz the power, 2016-08-09 08:17:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2016-08-09 08:21:42]

Description was changed from

==========
Add a feature which displays a "Remember my decision" toggle for permission
prompts.

This CL adds a disabled by default feature which shows a "Remember my
decision" toggle on permission prompts on Android. This is designed to
test whether a more explicit representation of permission persistence
(and better control over it) will encourage users to make decisions on
these prompts more often. It is intended to experiment with this
feature from M54.

A new PermissionInfoBar class is added to implement the optional
toggle. Permission-specific code in ConfirmInfoBar is moved into the
new class, which will also be beneficial in the future if permission
prompts stop being infobars. The permission decision is changed
from a boolean allowed/not allowed to the PermissionAction enum
already used for permission metrics reporting.

New metrics to measure the toggle position of prompts which are
granted or denied are also added in this CL to measure whether or
not users actually interact with the toggle (or if merely seeing it
is sufficient to change the wider permission action metrics).

A subsequent CL will implement a corresponding checkbox for
desktop permission prompts using the same feature. The desktop
permission decision will also be changed to a PermissionAction.

BUG=632269
==========

to

==========
Add a feature to display a persistence toggle for permission prompts on Android.

This CL adds a disabled by default feature which shows a "Remember my
decision" toggle on permission prompts on Android. This is designed to
test whether a more explicit representation of permission persistence
(and better control over it) will encourage users to make decisions on
these prompts more often. It is intended to experiment with this
feature from M54.

A new PermissionInfoBar class is added to implement the optional
toggle. Permission-specific code in ConfirmInfoBar is moved into the
new class, which will also be beneficial in the future if permission
prompts stop being infobars. The permission decision is changed
from a boolean allowed/not allowed to the PermissionAction enum
already used for permission metrics reporting.

New metrics to measure the toggle position of prompts which are
granted or denied are also added in this CL to measure whether or
not users actually interact with the toggle (or if merely seeing it
is sufficient to change the wider permission action metrics).

A subsequent CL will implement a corresponding checkbox for
desktop permission prompts using the same feature. The desktop
permission decision will also be changed to a PermissionAction.

BUG=632269
==========

[commit-bot: I haz the power, 2016-08-09 09:21:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 09:21:42]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dominickn, 2016-08-09 10:00:50]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 10:01:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 11:03:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 11:03:28]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-08-10 06:49:15]

dominickn@chromium.org changed reviewers:
+ tsergeant@chromium.org

[gone, 2016-08-10 17:47:53]

Surprisingly large cleanup.  Didn't realize we had so many different permissions
to bother a user for :/

https://chromiumcodereview.appspot.com/2226633002/diff/80001/chrome/android/j...
File chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java
(right):

https://chromiumcodereview.appspot.com/2226633002/diff/80001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java:168: *
ConfirmInfoBar.
From an interface standpoint, I think it might make more sense to take the extra
JNI hit to pull the persist boolean inside
PermissionInfoBarDelegate::ProcessButton().  Doing that means that
InfoBar/ConfirmInfoBar are insulated from that detail entirely.  WDYT?

https://chromiumcodereview.appspot.com/2226633002/diff/80001/chrome/android/j...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://chromiumcodereview.appspot.com/2226633002/diff/80001/chrome/android/j...
chrome/android/java/strings/android_chrome_strings.grd:1383: Remember my
decision
I know what I'm doing

Make me feel guilty about this later

Don't bother me again

Add to Home screen

[tsergeant, 2016-08-11 00:21:50]

I'm very happy about cleaning up the permissions stuff in ConfirmInfoBar 🙌

https://chromiumcodereview.appspot.com/2226633002/diff/80001/chrome/browser/p...
File chrome/browser/permissions/permission_uma_util.cc (right):

https://chromiumcodereview.appspot.com/2226633002/diff/80001/chrome/browser/p...
chrome/browser/permissions/permission_uma_util.cc:361:
UMA_HISTOGRAM_BOOLEAN("Permissions.Prompt.Granted.Persisted.Geolocation",
Maybe change the histogram names to

Permissions.Prompt.Accepted.Persisted.*

to match the existing Permissions.Prompt.Accepted metrics?

(Although you do need to be careful about directly comparing with those, since
they're not collected on Android yet).

[dominickn, 2016-08-11 04:43:42]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[dominickn, 2016-08-11 04:43:49]

Thanks!

https://codereview.chromium.org/2226633002/diff/80001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java
(right):

https://codereview.chromium.org/2226633002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java:168: *
ConfirmInfoBar.
On 2016/08/10 17:47:53, dfalcantara wrote:
> From an interface standpoint, I think it might make more sense to take the
extra
> JNI hit to pull the persist boolean inside
> PermissionInfoBarDelegate::ProcessButton().  Doing that means that
> InfoBar/ConfirmInfoBar are insulated from that detail entirely.  WDYT?

Done, moved to PermissionInfoBar.

https://codereview.chromium.org/2226633002/diff/80001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2226633002/diff/80001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:1383: Remember my
decision
On 2016/08/10 17:47:53, dfalcantara wrote:
> I know what I'm doing
> 
> Make me feel guilty about this later
> 
> Don't bother me again
> 
> Add to Home screen

Never gonna give you up.

https://codereview.chromium.org/2226633002/diff/80001/chrome/browser/permissi...
File chrome/browser/permissions/permission_uma_util.cc (right):

https://codereview.chromium.org/2226633002/diff/80001/chrome/browser/permissi...
chrome/browser/permissions/permission_uma_util.cc:361:
UMA_HISTOGRAM_BOOLEAN("Permissions.Prompt.Granted.Persisted.Geolocation",
On 2016/08/11 00:21:50, tsergeant wrote:
> Maybe change the histogram names to
> 
> Permissions.Prompt.Accepted.Persisted.*
> 
> to match the existing Permissions.Prompt.Accepted metrics?
> 
> (Although you do need to be careful about directly comparing with those, since
> they're not collected on Android yet).

Done.

[commit-bot: I haz the power, 2016-08-11 04:43:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 04:45:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 04:45:23]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[gone, 2016-08-12 18:42:11]

https://chromiumcodereview.appspot.com/2226633002/diff/100001/chrome/android/...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java
(right):

https://chromiumcodereview.appspot.com/2226633002/diff/100001/chrome/android/...
chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java:209:
private void onButtonClickedInternal(boolean isPrimaryButton) {
Does it make sense to just call super.onButtonClicked() instead of having this
call onButtonClicked again?  Seems like it'd get stuck in an infinite loop if
you hit cancel.

[dominickn, 2016-08-14 23:32:20]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-14 23:32:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2016-08-14 23:33:04]

dominickn@chromium.org changed reviewers:
+ raymes@chromium.org

[dominickn, 2016-08-14 23:33:05]

+raymes: PTAL at permissions, thanks!

https://codereview.chromium.org/2226633002/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java
(right):

https://codereview.chromium.org/2226633002/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java:209:
private void onButtonClickedInternal(boolean isPrimaryButton) {
On 2016/08/12 18:42:11, dfalcantara wrote:
> Does it make sense to just call super.onButtonClicked() instead of having this
> call onButtonClicked again?  Seems like it'd get stuck in an infinite loop if
> you hit cancel.

D'oh, makes sense. Override fail.

[commit-bot: I haz the power, 2016-08-14 23:50:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-14 23:50:00]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[dominickn, 2016-08-15 00:18:26]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 00:18:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 01:16:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 01:16:31]

Dry run: This issue passed the CQ dry run.

[gone, 2016-08-15 20:43:51]

lgtm

[raymes, 2016-08-16 01:44:54]

https://chromiumcodereview.appspot.com/2226633002/diff/140001/chrome/browser/...
File chrome/browser/permissions/permission_context_base_unittest.cc (right):

https://chromiumcodereview.appspot.com/2226633002/diff/140001/chrome/browser/...
chrome/browser/permissions/permission_context_base_unittest.cc:138:
PermissionAction decision = DISMISSED;
Since we're not just using this for UMA anymore, I feel like we should move it
out of permission_uma_util and put it somewhere more generic. Perhaps in
permission_util?

https://chromiumcodereview.appspot.com/2226633002/diff/140001/chrome/browser/...
File chrome/browser/permissions/permission_infobar_delegate.cc (right):

https://chromiumcodereview.appspot.com/2226633002/diff/140001/chrome/browser/...
chrome/browser/permissions/permission_infobar_delegate.cc:19: }
ordering is a funny thing but usually the constructor/destructor come first in
the cc file so perhaps move this down

https://chromiumcodereview.appspot.com/2226633002/diff/140001/chrome/browser/...
File chrome/browser/permissions/permission_infobar_delegate.h (right):

https://chromiumcodereview.appspot.com/2226633002/diff/140001/chrome/browser/...
chrome/browser/permissions/permission_infobar_delegate.h:40: base::string16
GetMessageText() const override;
nit: Did this need to move?

https://chromiumcodereview.appspot.com/2226633002/diff/140001/chrome/browser/...
chrome/browser/permissions/permission_infobar_delegate.h:76:
std::unique_ptr<infobars::InfoBar> CreatePermissionInfoBar(
Could this just live in permission_infobar?

https://chromiumcodereview.appspot.com/2226633002/diff/140001/chrome/browser/...
File chrome/browser/permissions/permission_queue_controller.cc (right):

https://chromiumcodereview.appspot.com/2226633002/diff/140001/chrome/browser/...
chrome/browser/permissions/permission_queue_controller.cc:235: }
The switch statement here seems kind of redundant. I wonder if we should just
expose RecordPermissionAction in permission_uma_util and call it directly?

https://chromiumcodereview.appspot.com/2226633002/diff/140001/chrome/browser/...
chrome/browser/permissions/permission_queue_controller.cc:237: if (decision !=
DISMISSED && update_content_setting)
Should this be a DCHECK instead? Actually I think we can move the DCHECK into
UpdateContentSetting and just have this here:

if (update_content_setting)
  UpdateContentSetting(...);


In UpdateContentSetting we can have:
DCHECK(decision == GRANTED || decision == DENIED);

https://chromiumcodereview.appspot.com/2226633002/diff/140001/chrome/browser/...
chrome/browser/permissions/permission_queue_controller.cc:283: content_setting =
CONTENT_SETTING_BLOCK;
optionally:
else
  DCHECK_EQ(DISMISSED, decision);

https://chromiumcodereview.appspot.com/2226633002/diff/140001/chrome/browser/...
File chrome/browser/permissions/permission_uma_util.cc (right):

https://chromiumcodereview.appspot.com/2226633002/diff/140001/chrome/browser/...
chrome/browser/permissions/permission_uma_util.cc:490: // The user is not
prompted for these permissions, thus there is no
nit: fill 80 chars

https://chromiumcodereview.appspot.com/2226633002/diff/140001/chrome/browser/...
chrome/browser/permissions/permission_uma_util.cc:537: // The user is not
prompted for these permissions, thus there is no
nit: fill 80 chars

https://chromiumcodereview.appspot.com/2226633002/diff/140001/chrome/browser/...
chrome/browser/permissions/permission_uma_util.cc:546: }
This is starting to get unwieldy so I think we should look at generating the
histogram names based on the permissions. I'm pretty sure this is possible. See
for example
https://cs.chromium.org/chromium/src/components/prefs/json_pref_store.cc?rcl=...

[dominickn, 2016-08-16 03:06:50]

Thanks!

https://codereview.chromium.org/2226633002/diff/140001/chrome/browser/permiss...
File chrome/browser/permissions/permission_context_base_unittest.cc (right):

https://codereview.chromium.org/2226633002/diff/140001/chrome/browser/permiss...
chrome/browser/permissions/permission_context_base_unittest.cc:138:
PermissionAction decision = DISMISSED;
On 2016/08/16 01:44:53, raymes wrote:
> Since we're not just using this for UMA anymore, I feel like we should move it
> out of permission_uma_util and put it somewhere more generic. Perhaps in
> permission_util?

Done.

https://codereview.chromium.org/2226633002/diff/140001/chrome/browser/permiss...
File chrome/browser/permissions/permission_infobar_delegate.cc (right):

https://codereview.chromium.org/2226633002/diff/140001/chrome/browser/permiss...
chrome/browser/permissions/permission_infobar_delegate.cc:19: }
On 2016/08/16 01:44:53, raymes wrote:
> ordering is a funny thing but usually the constructor/destructor come first in
> the cc file so perhaps move this down

Done.

https://codereview.chromium.org/2226633002/diff/140001/chrome/browser/permiss...
File chrome/browser/permissions/permission_infobar_delegate.h (right):

https://codereview.chromium.org/2226633002/diff/140001/chrome/browser/permiss...
chrome/browser/permissions/permission_infobar_delegate.h:40: base::string16
GetMessageText() const override;
On 2016/08/16 01:44:53, raymes wrote:
> nit: Did this need to move?

It must be public so that PermissionInfoBar can call it.

https://codereview.chromium.org/2226633002/diff/140001/chrome/browser/permiss...
chrome/browser/permissions/permission_infobar_delegate.h:76:
std::unique_ptr<infobars::InfoBar> CreatePermissionInfoBar(
On 2016/08/16 01:44:53, raymes wrote:
> Could this just live in permission_infobar?

That means we need to #include code in ui/android from geolocation, media,
notifications, etc. to create the infobars. Other infobar code follows a similar
pattern to this, which allows the InfoBar ui to be encompassed within the
delegate and it doesn't leak out.

https://codereview.chromium.org/2226633002/diff/140001/chrome/browser/permiss...
File chrome/browser/permissions/permission_queue_controller.cc (right):

https://codereview.chromium.org/2226633002/diff/140001/chrome/browser/permiss...
chrome/browser/permissions/permission_queue_controller.cc:235: }
On 2016/08/16 01:44:53, raymes wrote:
> The switch statement here seems kind of redundant. I wonder if we should just
> expose RecordPermissionAction in permission_uma_util and call it directly?

I'd like to deal with this in a follow up - there's a lot of metrics related
code which could be moved around like this. Filed crbug.com/638076. :)

https://codereview.chromium.org/2226633002/diff/140001/chrome/browser/permiss...
chrome/browser/permissions/permission_queue_controller.cc:237: if (decision !=
DISMISSED && update_content_setting)
On 2016/08/16 01:44:53, raymes wrote:
> Should this be a DCHECK instead? Actually I think we can move the DCHECK into
> UpdateContentSetting and just have this here:
> 
> if (update_content_setting)
>   UpdateContentSetting(...);
> 
> 
> In UpdateContentSetting we can have:
> DCHECK(decision == GRANTED || decision == DENIED);

Done.

https://codereview.chromium.org/2226633002/diff/140001/chrome/browser/permiss...
chrome/browser/permissions/permission_queue_controller.cc:283: content_setting =
CONTENT_SETTING_BLOCK;
On 2016/08/16 01:44:53, raymes wrote:
> optionally:
> else
>   DCHECK_EQ(DISMISSED, decision);

Done.

https://codereview.chromium.org/2226633002/diff/140001/chrome/browser/permiss...
File chrome/browser/permissions/permission_uma_util.cc (right):

https://codereview.chromium.org/2226633002/diff/140001/chrome/browser/permiss...
chrome/browser/permissions/permission_uma_util.cc:490: // The user is not
prompted for these permissions, thus there is no
On 2016/08/16 01:44:53, raymes wrote:
> nit: fill 80 chars

Done.

https://codereview.chromium.org/2226633002/diff/140001/chrome/browser/permiss...
chrome/browser/permissions/permission_uma_util.cc:537: // The user is not
prompted for these permissions, thus there is no
On 2016/08/16 01:44:53, raymes wrote:
> nit: fill 80 chars

Done.

https://codereview.chromium.org/2226633002/diff/140001/chrome/browser/permiss...
chrome/browser/permissions/permission_uma_util.cc:546: }
On 2016/08/16 01:44:53, raymes wrote:
> This is starting to get unwieldy so I think we should look at generating the
> histogram names based on the permissions. I'm pretty sure this is possible.
See
> for example
>
https://cs.chromium.org/chromium/src/components/prefs/json_pref_store.cc?rcl=...

Acknowledged. Filed crbug.com/638076 and assigned to myself.

[raymes, 2016-08-16 03:39:30]

lgtm

https://codereview.chromium.org/2226633002/diff/140001/chrome/browser/permiss...
File chrome/browser/permissions/permission_queue_controller.cc (right):

https://codereview.chromium.org/2226633002/diff/140001/chrome/browser/permiss...
chrome/browser/permissions/permission_queue_controller.cc:235: }
On 2016/08/16 03:06:50, dominickn wrote:
> On 2016/08/16 01:44:53, raymes wrote:
> > The switch statement here seems kind of redundant. I wonder if we should
just
> > expose RecordPermissionAction in permission_uma_util and call it directly?
> 
> I'd like to deal with this in a follow up - there's a lot of metrics related
> code which could be moved around like this. Filed crbug.com/638076. :)

sgtm, thanks!

https://codereview.chromium.org/2226633002/diff/160001/chrome/browser/permiss...
File chrome/browser/permissions/permission_context_base_unittest.cc (right):

https://codereview.chromium.org/2226633002/diff/160001/chrome/browser/permiss...
chrome/browser/permissions/permission_context_base_unittest.cc:22: #include
"chrome/browser/permissions/permission_uma_util.h"
nit: is this still needed?

https://codereview.chromium.org/2226633002/diff/160001/chrome/browser/permiss...
File chrome/browser/permissions/permission_infobar_delegate.h (right):

https://codereview.chromium.org/2226633002/diff/160001/chrome/browser/permiss...
chrome/browser/permissions/permission_infobar_delegate.h:12: #include
"chrome/browser/permissions/permission_uma_util.h"
nit: permission_util.h

https://codereview.chromium.org/2226633002/diff/160001/chrome/browser/permiss...
chrome/browser/permissions/permission_infobar_delegate.h:38: void
SetPersist(bool persist) { persist_ = persist; }
nit: setters like this are generally styled:
void set_persist(bool persist) { ... }

https://codereview.chromium.org/2226633002/diff/160001/chrome/browser/permiss...
chrome/browser/permissions/permission_infobar_delegate.h:40: base::string16
GetMessageText() const override;
nit: add // ConfirmInfoBarDelegate:

https://codereview.chromium.org/2226633002/diff/160001/chrome/browser/permiss...
File chrome/browser/permissions/permission_queue_controller.h (right):

https://codereview.chromium.org/2226633002/diff/160001/chrome/browser/permiss...
chrome/browser/permissions/permission_queue_controller.h:10: #include
"chrome/browser/permissions/permission_uma_util.h"
permission_util.h

[dominickn, 2016-08-16 03:54:23]

dominickn@chromium.org changed reviewers:
+ isherman@chromium.org, thestig@chromium.org

[dominickn, 2016-08-16 04:13:49]

Description was changed from

==========
Add a feature to display a persistence toggle for permission prompts on Android.

This CL adds a disabled by default feature which shows a "Remember my
decision" toggle on permission prompts on Android. This is designed to
test whether a more explicit representation of permission persistence
(and better control over it) will encourage users to make decisions on
these prompts more often. It is intended to experiment with this
feature from M54.

A new PermissionInfoBar class is added to implement the optional
toggle. Permission-specific code in ConfirmInfoBar is moved into the
new class, which will also be beneficial in the future if permission
prompts stop being infobars. The permission decision is changed
from a boolean allowed/not allowed to the PermissionAction enum
already used for permission metrics reporting.

New metrics to measure the toggle position of prompts which are
granted or denied are also added in this CL to measure whether or
not users actually interact with the toggle (or if merely seeing it
is sufficient to change the wider permission action metrics).

A subsequent CL will implement a corresponding checkbox for
desktop permission prompts using the same feature. The desktop
permission decision will also be changed to a PermissionAction.

BUG=632269
==========

to

==========
Add a feature to display a persistence toggle for permission prompts on Android.

This CL adds a disabled by default feature which shows a "Remember my
decision" toggle on permission prompts on Android. This is designed to
test whether a more explicit representation of permission persistence
(and better control over it) will encourage users to make decisions on
these prompts more often. It is intended to experiment with this
feature from M54.

A new PermissionInfoBar class is added to implement the optional
toggle. Permission-specific code in ConfirmInfoBar is moved into the
new class, which will also be beneficial in the future if permission
prompts stop being infobars. The permission decision is changed
from a boolean allowed/not allowed to the PermissionAction enum
already used for permission metrics reporting.

New metrics to measure the toggle position of prompts which are
granted or denied are also added in this CL to measure whether or
not users actually interact with the toggle (or if merely seeing it
is sufficient to change the wider permission action metrics).

The toggle is explicitly disabled for notification infobars as it does
not make sense to grant a non-persisted notification permission.

A subsequent CL will implement a corresponding checkbox for
desktop permission prompts using the same feature. The desktop
permission decision will also be changed to a PermissionAction.

BUG=632269
==========

[dominickn, 2016-08-16 04:15:41]

dominickn@chromium.org changed reviewers:
+ dewittj@chromium.org

[dominickn, 2016-08-16 04:15:43]

Thanks!

+dewittj: PTAL at notification_infobar_delegate
+isherman: PTAL at histograms
+thestig: PTAL at chrome/common, and RS the API change in geolocation and media

https://codereview.chromium.org/2226633002/diff/160001/chrome/browser/permiss...
File chrome/browser/permissions/permission_context_base_unittest.cc (right):

https://codereview.chromium.org/2226633002/diff/160001/chrome/browser/permiss...
chrome/browser/permissions/permission_context_base_unittest.cc:22: #include
"chrome/browser/permissions/permission_uma_util.h"
On 2016/08/16 03:39:29, raymes wrote:
> nit: is this still needed?

Done.

https://codereview.chromium.org/2226633002/diff/160001/chrome/browser/permiss...
File chrome/browser/permissions/permission_infobar_delegate.h (right):

https://codereview.chromium.org/2226633002/diff/160001/chrome/browser/permiss...
chrome/browser/permissions/permission_infobar_delegate.h:12: #include
"chrome/browser/permissions/permission_uma_util.h"
On 2016/08/16 03:39:29, raymes wrote:
> nit: permission_util.h

Done.

https://codereview.chromium.org/2226633002/diff/160001/chrome/browser/permiss...
chrome/browser/permissions/permission_infobar_delegate.h:38: void
SetPersist(bool persist) { persist_ = persist; }
On 2016/08/16 03:39:29, raymes wrote:
> nit: setters like this are generally styled:
> void set_persist(bool persist) { ... }

Done.

https://codereview.chromium.org/2226633002/diff/160001/chrome/browser/permiss...
chrome/browser/permissions/permission_infobar_delegate.h:40: base::string16
GetMessageText() const override;
On 2016/08/16 03:39:29, raymes wrote:
> nit: add // ConfirmInfoBarDelegate:

Done.

https://codereview.chromium.org/2226633002/diff/160001/chrome/browser/permiss...
File chrome/browser/permissions/permission_queue_controller.h (right):

https://codereview.chromium.org/2226633002/diff/160001/chrome/browser/permiss...
chrome/browser/permissions/permission_queue_controller.h:10: #include
"chrome/browser/permissions/permission_uma_util.h"
On 2016/08/16 03:39:29, raymes wrote:
> permission_util.h

Done.

[Lei Zhang, 2016-08-16 04:25:49]

lgtm

https://codereview.chromium.org/2226633002/diff/180001/chrome/browser/geoloca...
File chrome/browser/geolocation/geolocation_infobar_delegate_android.h (right):

https://codereview.chromium.org/2226633002/diff/180001/chrome/browser/geoloca...
chrome/browser/geolocation/geolocation_infobar_delegate_android.h:13: class
InfoBarService;
BTW, the Google C++ Style Guide changed at some point w.r.t. to forward
declarations.
https://google.github.io/styleguide/cppguide.html#Forward_Declarations

I don't make the decisions, just the messenger.

[dominickn, 2016-08-16 04:36:58]

On 2016/08/16 04:25:49, Lei Zhang wrote:
> lgtm
> 
>
https://codereview.chromium.org/2226633002/diff/180001/chrome/browser/geoloca...
> File chrome/browser/geolocation/geolocation_infobar_delegate_android.h
(right):
> 
>
https://codereview.chromium.org/2226633002/diff/180001/chrome/browser/geoloca...
> chrome/browser/geolocation/geolocation_infobar_delegate_android.h:13: class
> InfoBarService;
> BTW, the Google C++ Style Guide changed at some point w.r.t. to forward
> declarations.
> https://google.github.io/styleguide/cppguide.html#Forward_Declarations
> 
> I don't make the decisions, just the messenger.

The Chromium style guide explicitly prefers forward declarations (and calls out
the difference to the Google one) -
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md....
I was following this.

[Ilya Sherman, 2016-08-16 04:41:54]

Metrics LGTM % a nit:

https://codereview.chromium.org/2226633002/diff/180001/tools/metrics/histogra...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2226633002/diff/180001/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:39904: +<histogram
name="Permissions.Prompt.Accepted.Persisted" enum="BooleanEnabled">
Please provide an enum with custom labels for persist vs. don't persist (just
within this file -- no need to make C++ changes)

https://codereview.chromium.org/2226633002/diff/180001/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:39922: +<histogram
name="Permissions.Prompt.Denied.Persisted" enum="BooleanEnabled">
Ditto.

[Lei Zhang, 2016-08-16 04:42:02]

On 2016/08/16 04:36:58, dominickn wrote:
> The Chromium style guide explicitly prefers forward declarations (and calls
out
> the difference to the Google one) -
>
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md....
> I was following this.

Doh. Thanks for pointing that out. I never get the memo.

[dominickn, 2016-08-16 04:49:05]

Description was changed from

==========
Add a feature to display a persistence toggle for permission prompts on Android.

This CL adds a disabled by default feature which shows a "Remember my
decision" toggle on permission prompts on Android. This is designed to
test whether a more explicit representation of permission persistence
(and better control over it) will encourage users to make decisions on
these prompts more often. It is intended to experiment with this
feature from M54.

A new PermissionInfoBar class is added to implement the optional
toggle. Permission-specific code in ConfirmInfoBar is moved into the
new class, which will also be beneficial in the future if permission
prompts stop being infobars. The permission decision is changed
from a boolean allowed/not allowed to the PermissionAction enum
already used for permission metrics reporting.

New metrics to measure the toggle position of prompts which are
granted or denied are also added in this CL to measure whether or
not users actually interact with the toggle (or if merely seeing it
is sufficient to change the wider permission action metrics).

The toggle is explicitly disabled for notification infobars as it does
not make sense to grant a non-persisted notification permission.

A subsequent CL will implement a corresponding checkbox for
desktop permission prompts using the same feature. The desktop
permission decision will also be changed to a PermissionAction.

BUG=632269
==========

to

==========
Add a feature to display a persistence toggle for permission prompts on Android.

This CL adds a disabled by default feature which shows a "Remember my
decision" toggle on permission prompts on Android. This is designed to
test whether a more explicit representation of permission persistence
(and better control over it) will encourage users to make decisions on
these prompts more often. It is intended to experiment with this
feature from M54.

A new PermissionInfoBar class is added to implement the optional
toggle. Permission-specific code in ConfirmInfoBar is moved into the
new class, which will also be beneficial in the future if permission
prompts stop being infobars. The permission decision is changed
from a boolean allowed/not allowed to the PermissionAction enum
already used for permission metrics reporting.

New metrics to measure the toggle position of prompts which are
granted or denied are also added in this CL to measure whether or
not users actually interact with the toggle (or if merely seeing it
is sufficient to change the wider permission action metrics).

The toggle is explicitly disabled for all permissions except
geolocation, which currently generates the most prompts on Android.

A subsequent CL will implement a corresponding checkbox for
desktop permission prompts using the same feature. The desktop
permission decision will also be changed to a PermissionAction.

BUG=632269
==========

[dominickn, 2016-08-16 04:49:05]

dominickn@chromium.org changed reviewers:
- dewittj@chromium.org

[dominickn, 2016-08-16 04:50:16]

Thanks!

dewittj: moved you to CC list as the change in notifications/ has gone back to a
trivial API change.

https://codereview.chromium.org/2226633002/diff/180001/tools/metrics/histogra...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2226633002/diff/180001/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:39904: +<histogram
name="Permissions.Prompt.Accepted.Persisted" enum="BooleanEnabled">
On 2016/08/16 04:41:54, Ilya Sherman wrote:
> Please provide an enum with custom labels for persist vs. don't persist (just
> within this file -- no need to make C++ changes)

Done.

https://codereview.chromium.org/2226633002/diff/180001/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:39922: +<histogram
name="Permissions.Prompt.Denied.Persisted" enum="BooleanEnabled">
On 2016/08/16 04:41:54, Ilya Sherman wrote:
> Ditto.

Done.

[raymes, 2016-08-16 04:51:58]

lgtm

https://codereview.chromium.org/2226633002/diff/200001/chrome/browser/permiss...
File chrome/browser/permissions/permission_uma_util.cc (right):

https://codereview.chromium.org/2226633002/diff/200001/chrome/browser/permiss...
chrome/browser/permissions/permission_uma_util.cc:545: }
nit: maybe we should just have geolocation here for now?

[dominickn, 2016-08-16 04:54:51]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 04:55:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 05:49:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 05:49:48]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-08-16 06:02:25]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2016-08-16 06:02:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org, thestig@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2226633002/#ps200001
(title: "Address nits, verbal change to make it geolocation-only")

[commit-bot: I haz the power, 2016-08-16 06:02:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 06:06:53]

Description was changed from

==========
Add a feature to display a persistence toggle for permission prompts on Android.

This CL adds a disabled by default feature which shows a "Remember my
decision" toggle on permission prompts on Android. This is designed to
test whether a more explicit representation of permission persistence
(and better control over it) will encourage users to make decisions on
these prompts more often. It is intended to experiment with this
feature from M54.

A new PermissionInfoBar class is added to implement the optional
toggle. Permission-specific code in ConfirmInfoBar is moved into the
new class, which will also be beneficial in the future if permission
prompts stop being infobars. The permission decision is changed
from a boolean allowed/not allowed to the PermissionAction enum
already used for permission metrics reporting.

New metrics to measure the toggle position of prompts which are
granted or denied are also added in this CL to measure whether or
not users actually interact with the toggle (or if merely seeing it
is sufficient to change the wider permission action metrics).

The toggle is explicitly disabled for all permissions except
geolocation, which currently generates the most prompts on Android.

A subsequent CL will implement a corresponding checkbox for
desktop permission prompts using the same feature. The desktop
permission decision will also be changed to a PermissionAction.

BUG=632269
==========

to

==========
Add a feature to display a persistence toggle for permission prompts on Android.

This CL adds a disabled by default feature which shows a "Remember my
decision" toggle on permission prompts on Android. This is designed to
test whether a more explicit representation of permission persistence
(and better control over it) will encourage users to make decisions on
these prompts more often. It is intended to experiment with this
feature from M54.

A new PermissionInfoBar class is added to implement the optional
toggle. Permission-specific code in ConfirmInfoBar is moved into the
new class, which will also be beneficial in the future if permission
prompts stop being infobars. The permission decision is changed
from a boolean allowed/not allowed to the PermissionAction enum
already used for permission metrics reporting.

New metrics to measure the toggle position of prompts which are
granted or denied are also added in this CL to measure whether or
not users actually interact with the toggle (or if merely seeing it
is sufficient to change the wider permission action metrics).

The toggle is explicitly disabled for all permissions except
geolocation, which currently generates the most prompts on Android.

A subsequent CL will implement a corresponding checkbox for
desktop permission prompts using the same feature. The desktop
permission decision will also be changed to a PermissionAction.

BUG=632269
==========

[commit-bot: I haz the power, 2016-08-16 06:06:55]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-08-16 06:08:37]

Description was changed from

==========
Add a feature to display a persistence toggle for permission prompts on Android.

This CL adds a disabled by default feature which shows a "Remember my
decision" toggle on permission prompts on Android. This is designed to
test whether a more explicit representation of permission persistence
(and better control over it) will encourage users to make decisions on
these prompts more often. It is intended to experiment with this
feature from M54.

A new PermissionInfoBar class is added to implement the optional
toggle. Permission-specific code in ConfirmInfoBar is moved into the
new class, which will also be beneficial in the future if permission
prompts stop being infobars. The permission decision is changed
from a boolean allowed/not allowed to the PermissionAction enum
already used for permission metrics reporting.

New metrics to measure the toggle position of prompts which are
granted or denied are also added in this CL to measure whether or
not users actually interact with the toggle (or if merely seeing it
is sufficient to change the wider permission action metrics).

The toggle is explicitly disabled for all permissions except
geolocation, which currently generates the most prompts on Android.

A subsequent CL will implement a corresponding checkbox for
desktop permission prompts using the same feature. The desktop
permission decision will also be changed to a PermissionAction.

BUG=632269
==========

to

==========
Add a feature to display a persistence toggle for permission prompts on Android.

This CL adds a disabled by default feature which shows a "Remember my
decision" toggle on permission prompts on Android. This is designed to
test whether a more explicit representation of permission persistence
(and better control over it) will encourage users to make decisions on
these prompts more often. It is intended to experiment with this
feature from M54.

A new PermissionInfoBar class is added to implement the optional
toggle. Permission-specific code in ConfirmInfoBar is moved into the
new class, which will also be beneficial in the future if permission
prompts stop being infobars. The permission decision is changed
from a boolean allowed/not allowed to the PermissionAction enum
already used for permission metrics reporting.

New metrics to measure the toggle position of prompts which are
granted or denied are also added in this CL to measure whether or
not users actually interact with the toggle (or if merely seeing it
is sufficient to change the wider permission action metrics).

The toggle is explicitly disabled for all permissions except
geolocation, which currently generates the most prompts on Android.

A subsequent CL will implement a corresponding checkbox for
desktop permission prompts using the same feature. The desktop
permission decision will also be changed to a PermissionAction.

BUG=632269

Committed: https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd
Cr-Commit-Position: refs/heads/master@{#412177}
==========

[commit-bot: I haz the power, 2016-08-16 06:08:39]

Patchset 11 (id:??) landed as
https://crrev.com/6957a9ca3f6db210572d6b54dcbcf69baeb978fd
Cr-Commit-Position: refs/heads/master@{#412177}