Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2251673002: Add tests for the geolocation prompt with persistence switch on Android. (Closed)

Created:
4 years, 4 months ago by dominickn
Modified:
4 years, 4 months ago
Reviewers:
gone
CC:
chromium-reviews, raymes
Base URL:
https://chromium.googlesource.com/chromium/src.git@permission-infobar-remember-decision
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests for the geolocation prompt with persistence switch on Android. This CL explicitly enables the persistence toggle for geolocation prompts on Android, and tests geolocation requests with the toggle on and off. BUG=632269 Committed: https://crrev.com/0fddca1b8dc2abf1733e1ce4640e915d1c19aa16 Cr-Commit-Position: refs/heads/master@{#412695}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -0 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java View 3 chunks +127 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (11 generated)
dominickn
PTAL, thanks!
4 years, 4 months ago (2016-08-16 08:39:08 UTC) #4
gone
lgtm
4 years, 4 months ago (2016-08-17 17:40:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251673002/1
4 years, 4 months ago (2016-08-17 22:44:44 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 23:51:12 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 00:01:29 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fddca1b8dc2abf1733e1ce4640e915d1c19aa16
Cr-Commit-Position: refs/heads/master@{#412695}

Powered by Google App Engine
This is Rietveld 408576698