Add a feature to display a persistence toggle for permission prompts on Android.

chrome/browser/permissions/permission_uma_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_uma_util.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 429 matching lines @@
     // ignore recorded for them.
     case PermissionType::MIDI:
     case PermissionType::BACKGROUND_SYNC:
     case PermissionType::NUM:
       NOTREACHED() << "PERMISSION "
                    << PermissionUtil::GetPermissionString(permission)
                    << " not accounted for";
   }
 }
 
+void PermissionUmaUtil::PermissionPromptAcceptedWithPersistenceToggle(
+    content::PermissionType permission,
+    bool toggle_enabled) {
+  switch (permission) {
+    case PermissionType::GEOLOCATION:
+      UMA_HISTOGRAM_BOOLEAN("Permissions.Prompt.Accepted.Persisted.Geolocation",
+                            toggle_enabled);
+      break;
+    case PermissionType::NOTIFICATIONS:
+      UMA_HISTOGRAM_BOOLEAN(
+          "Permissions.Prompt.Accepted.Persisted.Notifications",
+          toggle_enabled);
+      break;
+    case PermissionType::MIDI_SYSEX:
+      UMA_HISTOGRAM_BOOLEAN("Permissions.Prompt.Accepted.Persisted.MidiSysEx",
+                            toggle_enabled);
+      break;
+    case PermissionType::PUSH_MESSAGING:
+      UMA_HISTOGRAM_BOOLEAN(
+          "Permissions.Prompt.Accepted.Persisted.PushMessaging",
+          toggle_enabled);
+      break;
+    case PermissionType::PROTECTED_MEDIA_IDENTIFIER:
+      UMA_HISTOGRAM_BOOLEAN(
+          "Permissions.Prompt.Accepted.Persisted.ProtectedMedia",
+          toggle_enabled);
+      break;
+    case PermissionType::DURABLE_STORAGE:
+      UMA_HISTOGRAM_BOOLEAN(
+          "Permissions.Prompt.Accepted.Persisted.DurableStorage",
+          toggle_enabled);
+      break;
+    case PermissionType::AUDIO_CAPTURE:
+      UMA_HISTOGRAM_BOOLEAN(
+          "Permissions.Prompt.Accepted.Persisted.AudioCapture", toggle_enabled);
+      break;
+    case PermissionType::VIDEO_CAPTURE:
+      UMA_HISTOGRAM_BOOLEAN(
+          "Permissions.Prompt.Accepted.Persisted.VideoCapture", toggle_enabled);
+      break;
+    // The user is not prompted for these permissions, thus there is no

[raymes, 2016/08/16 01:44:53]

nit: fill 80 chars

[dominickn, 2016/08/16 03:06:50]

Done.

+    // accept recorded for them.
+    case PermissionType::MIDI:
+    case PermissionType::BACKGROUND_SYNC:
+    case PermissionType::NUM:
+      NOTREACHED() << "PERMISSION "
+                   << PermissionUtil::GetPermissionString(permission)
+                   << " not accounted for";
+  }
+}
+
+void PermissionUmaUtil::PermissionPromptDeniedWithPersistenceToggle(
+    content::PermissionType permission,
+    bool toggle_enabled) {
+  switch (permission) {
+    case PermissionType::GEOLOCATION:
+      UMA_HISTOGRAM_BOOLEAN("Permissions.Prompt.Denied.Persisted.Geolocation",
+                            toggle_enabled);
+      break;
+    case PermissionType::NOTIFICATIONS:
+      UMA_HISTOGRAM_BOOLEAN("Permissions.Prompt.Denied.Persisted.Notifications",
+                            toggle_enabled);
+      break;
+    case PermissionType::MIDI_SYSEX:
+      UMA_HISTOGRAM_BOOLEAN("Permissions.Prompt.Denied.Persisted.MidiSysEx",
+                            toggle_enabled);
+      break;
+    case PermissionType::PUSH_MESSAGING:
+      UMA_HISTOGRAM_BOOLEAN("Permissions.Prompt.Denied.Persisted.PushMessaging",
+                            toggle_enabled);
+      break;
+    case PermissionType::PROTECTED_MEDIA_IDENTIFIER:
+      UMA_HISTOGRAM_BOOLEAN(
+          "Permissions.Prompt.Denied.Persisted.ProtectedMedia", toggle_enabled);
+      break;
+    case PermissionType::DURABLE_STORAGE:
+      UMA_HISTOGRAM_BOOLEAN(
+          "Permissions.Prompt.Denied.Persisted.DurableStorage", toggle_enabled);
+      break;
+    case PermissionType::AUDIO_CAPTURE:
+      UMA_HISTOGRAM_BOOLEAN("Permissions.Prompt.Denied.Persisted.AudioCapture",
+                            toggle_enabled);
+      break;
+    case PermissionType::VIDEO_CAPTURE:
+      UMA_HISTOGRAM_BOOLEAN("Permissions.Prompt.Denied.Persisted.VideoCapture",
+                            toggle_enabled);
+      break;
+    // The user is not prompted for these permissions, thus there is no

[raymes, 2016/08/16 01:44:53]

nit: fill 80 chars

[dominickn, 2016/08/16 03:06:50]

Done.

+    // deny recorded for them.
+    case PermissionType::MIDI:
+    case PermissionType::BACKGROUND_SYNC:
+    case PermissionType::NUM:
+      NOTREACHED() << "PERMISSION "
+                   << PermissionUtil::GetPermissionString(permission)
+                   << " not accounted for";
+  }
+}

[raymes, 2016/08/16 01:44:53]

This is starting to get unwieldy so I think we should look at generating the
histogram names based on the permissions. I'm pretty sure this is possible. See
for example
https://cs.chromium.org/chromium/src/components/prefs/json_pref_store.cc?rcl=...

[dominickn, 2016/08/16 03:06:50]

Acknowledged. Filed crbug.com/638076 and assigned to myself.

+
 bool PermissionUmaUtil::IsOptedIntoPermissionActionReporting(Profile* profile) {
   if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnablePermissionActionReporting))
     return false;
 
   DCHECK(profile);
   if (profile->GetProfileType() == Profile::INCOGNITO_PROFILE)
     return false;
   if (!profile->GetPrefs()->GetBoolean(prefs::kSafeBrowsingEnabled))
     return false;
@@ skipping 103 matching lines @@
   if (!deprecated_metric.empty() && rappor_service) {
     rappor::SampleDomainAndRegistryFromGURL(rappor_service, deprecated_metric,
                                             requesting_origin);
 
     std::string rappor_metric = deprecated_metric + "2";
     rappor_service->RecordSample(
         rappor_metric, rappor::LOW_FREQUENCY_ETLD_PLUS_ONE_RAPPOR_TYPE,
         rappor::GetDomainAndRegistrySampleFromGURL(requesting_origin));
   }
 }