chrome/browser/geolocation/geolocation_infobar_delegate_android.cc - Issue 2226633002: Add a feature to display a persistence toggle for permission prompts on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_infobar_delegate_android.cc

Issue 2226633002: Add a feature to display a persistence toggle for permission prompts on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits, verbal change to make it geolocation-only Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/geolocation_infobar_delegate_android.h ('k') | chrome/browser/media/midi_permission_infobar_delegate_android.cc » ('j') | chrome/browser/permissions/permission_uma_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_infobar_delegate_android.cc

diff --git a/chrome/browser/geolocation/geolocation_infobar_delegate_android.cc b/chrome/browser/geolocation/geolocation_infobar_delegate_android.cc

index 780c70cfd61898c6f623b7041fca6b7bb9637cb1..33a4917f0cfed0c812882749286caa6f0ed6fa40 100644

--- a/chrome/browser/geolocation/geolocation_infobar_delegate_android.cc

+++ b/chrome/browser/geolocation/geolocation_infobar_delegate_android.cc

@@ -17,8 +17,8 @@ infobars::InfoBar* GeolocationInfoBarDelegateAndroid::Create(

bool user_gesture,

Profile* profile,

const PermissionSetCallback& callback) {

- return infobar_service->AddInfoBar(infobar_service->CreateConfirmInfoBar(

- std::unique_ptr<ConfirmInfoBarDelegate>(

+ return infobar_service->AddInfoBar(

+ CreatePermissionInfoBar(std::unique_ptr<PermissionInfobarDelegate>(

new GeolocationInfoBarDelegateAndroid(requesting_frame, user_gesture,

profile, callback))));

}