chrome/browser/permissions/permission_queue_controller.h - Issue 2226633002: Add a feature to display a persistence toggle for permission prompts on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_queue_controller.h

Issue 2226633002: Add a feature to display a persistence toggle for permission prompts on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits, verbal change to make it geolocation-only Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/permission_infobar_delegate.cc ('k') | chrome/browser/permissions/permission_queue_controller.cc » ('j') | chrome/browser/permissions/permission_uma_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_queue_controller.h

diff --git a/chrome/browser/permissions/permission_queue_controller.h b/chrome/browser/permissions/permission_queue_controller.h

index 869486d5212de0ece02645fe644272b0b30685b9..1cecd224b30f0eb61b595c618c4cd1cd9ef7419f 100644

--- a/chrome/browser/permissions/permission_queue_controller.h

+++ b/chrome/browser/permissions/permission_queue_controller.h

@@ -7,6 +7,7 @@

#include "base/bind.h"

#include "base/macros.h"

+#include "chrome/browser/permissions/permission_util.h"

#include "components/content_settings/core/common/content_settings.h"

#include "components/content_settings/core/common/content_settings_types.h"

#include "content/public/browser/notification_observer.h"

@@ -54,12 +55,13 @@ class PermissionQueueController : public content::NotificationObserver {

const GURL& embedder,

bool user_gesture,

bool update_content_setting,

- bool allowed);

+ PermissionAction decision);

// Performs the update to content settings for a particular request frame

// context.

- void UpdateContentSetting(

- const GURL& requesting_frame, const GURL& embedder, bool allowed);

+ void UpdateContentSetting(const GURL& requesting_frame,

+ const GURL& embedder,

+ PermissionAction decision);

protected:

// content::NotificationObserver: