|
Allow grid positions to be named grid areas
This change extends our handling of grid position to allow for
named grid areas. This required to split the shorthands parsing
between grid-{row|column} and grid-area as the rules for expanding
are slightly different. The patch reuses a lot of the existing logic
to marshall the values into RenderStyle.
One big difference after this change is that:
grid-row: foobar / none;
used to be rejected at parsing but is now allowed.
BUG= 258092
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155555
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+292 lines, -48 lines) |
Patch |
|
M |
LayoutTests/fast/css-grid-layout/grid-item-area-get-set.html
|
View
|
|
3 chunks |
+23 lines, -0 lines |
0 comments
|
Download
|
|
M |
LayoutTests/fast/css-grid-layout/grid-item-area-get-set-expected.txt
|
View
|
|
2 chunks |
+12 lines, -0 lines |
0 comments
|
Download
|
|
M |
LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html
|
View
|
|
5 chunks |
+39 lines, -21 lines |
0 comments
|
Download
|
|
M |
LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set-expected.txt
|
View
|
|
3 chunks |
+30 lines, -6 lines |
0 comments
|
Download
|
|
M |
LayoutTests/fast/css-grid-layout/grid-item-end-after-get-set.html
|
View
|
|
5 chunks |
+14 lines, -0 lines |
0 comments
|
Download
|
|
M |
LayoutTests/fast/css-grid-layout/grid-item-end-after-get-set-expected.txt
|
View
|
|
2 chunks |
+24 lines, -0 lines |
0 comments
|
Download
|
|
M |
LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html
|
View
|
|
5 chunks |
+14 lines, -0 lines |
0 comments
|
Download
|
|
M |
LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set-expected.txt
|
View
|
|
2 chunks |
+24 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/css/CSSComputedStyleDeclaration.cpp
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/css/CSSParser.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
Source/core/css/CSSParser-in.cpp
|
View
|
|
3 chunks |
+84 lines, -14 lines |
0 comments
|
Download
|
|
M |
Source/core/css/resolver/StyleBuilderCustom.cpp
|
View
|
|
1 chunk |
+9 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/rendering/RenderGrid.cpp
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
Source/core/rendering/style/GridPosition.h
|
View
|
|
4 chunks |
+10 lines, -2 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|