Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html

Issue 22215002: Allow grid positions to be named grid areas (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html
diff --git a/LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html b/LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html
index 37829409e3e1553af92fe9006a811962c2929e0d..e28bec0610f6e38e9b79762a17a2ab0dda4b1d5d 100644
--- a/LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html
+++ b/LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html
@@ -3,6 +3,11 @@
<head>
<link href="resources/grid.css" rel="stylesheet">
<style>
+.grid {
+ grid-template: "firstArea" "secondArea"
+ "thirdArea" "thirdArea";
+}
+
.gridItemWithPositiveInteger {
grid-column-start: 10;
grid-row-start: 15;
@@ -39,6 +44,10 @@
grid-column-start: 2 "first" span;
grid-row-start: "last" 3 span;
}
+.gridItemWithArea {
+ grid-column-start: firstArea;
+ grid-row-start: thirdArea;
+}
</style>
<script src="resources/grid-item-column-row-parsing-utils.js"></script>
<script src="../js/resources/js-test-pre.js"></script>
@@ -56,6 +65,7 @@
<div class="gridItemWithString" id="gridItemWithStringElement"></div>
<div class="gridItemWithSpanString" id="gridItemWithSpanStringElement"></div>
<div class="gridItemWithSpanNumberString" id="gridItemWithSpanNumberStringElement"></div>
+ <div class="gridItemWithArea" id="gridItemWithArea"></div>
</div>
<script>
description('Test that setting and getting grid-column-start and grid-row-start works as expected');
@@ -76,6 +86,7 @@
testColumnRowCSSParsing("gridItemWithStringElement", "1 first / auto", "1 last / auto");
testColumnRowCSSParsing("gridItemWithSpanStringElement", "span 1 first / auto", "span 1 last / auto");
testColumnRowCSSParsing("gridItemWithSpanNumberStringElement", "span 2 first / auto", "span 3 last / auto");
+ testColumnRowCSSParsing("gridItemWithArea", "firstArea / auto", "thirdArea / auto");
debug("");
debug("Test the initial value");
@@ -94,6 +105,9 @@
testColumnStartRowStartJSParsing("span 3", "span 20");
testColumnStartRowStartJSParsing("span 'nav'", "span 'last'", "span 1 nav", "span 1 last");
testColumnStartRowStartJSParsing("auto", "auto");
+ testColumnStartRowStartJSParsing("thirdArea", "secondArea");
+ testColumnStartRowStartJSParsing("nonExistentArea", "secondArea", "nonExistentArea", "secondArea");
+ testColumnStartRowStartJSParsing("secondArea", "nonExistentArea", "secondArea", "nonExistentArea");
debug("");
debug("Test setting grid-column-start and grid-row-start to 'inherit' through JS");

Powered by Google App Engine
This is Rietveld 408576698