Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: LayoutTests/fast/css-grid-layout/grid-item-area-get-set.html

Issue 22215002: Allow grid positions to be named grid areas (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-item-area-get-set-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/css-grid-layout/grid-item-area-get-set.html
diff --git a/LayoutTests/fast/css-grid-layout/grid-item-area-get-set.html b/LayoutTests/fast/css-grid-layout/grid-item-area-get-set.html
index 10f89ac5bf5df958eb7960594761c81d6038f383..2c9743858b23fa013fbf35071a911219d4a3361d 100644
--- a/LayoutTests/fast/css-grid-layout/grid-item-area-get-set.html
+++ b/LayoutTests/fast/css-grid-layout/grid-item-area-get-set.html
@@ -3,14 +3,27 @@
<head>
<link href="resources/grid.css" rel="stylesheet">
<style>
+.grid {
+ grid-template: "firstArea" "secondArea"
+ "thirdArea" "thirdArea";
+}
+
#oneValueGridArea {
grid-area: 1;
}
+#oneValueIdentGridArea {
+ grid-area: thirdArea;
+}
+
#twoValueGridArea {
grid-area: -1 / span 1;
}
+#twoValueIdentGridArea {
+ grid-area: firstArea / secondArea;
+}
+
#threeValueGridArea {
grid-area: span / 10 / -1;
}
@@ -18,15 +31,22 @@
#fourValueGridArea {
grid-area: -5 / 5 span / span 8 / 9;
}
+
+#fourValueMixedGridArea {
+ grid-area: firstArea / span / nonExistent / "foobar";
+}
</style>
<script src="../js/resources/js-test-pre.js"></script>
</head>
<body>
<div class="grid">
<div id="oneValueGridArea"></div>
+ <div id="oneValueIdentGridArea"></div>
<div id="twoValueGridArea"></div>
+ <div id="twoValueIdentGridArea"></div>
<div id="threeValueGridArea"></div>
<div id="fourValueGridArea"></div>
+ <div id="fourValueMixedGridArea"></div>
</div>
<script>
description('This test checks that grid-area is properly parsed and stored internally.');
@@ -104,9 +124,12 @@
debug("Test getting grid-area set through CSS");
testGridAreaCSSParsing("oneValueGridArea", "1");
+ testGridAreaCSSParsing("oneValueIdentGridArea", "thirdArea", "thirdArea", "thirdArea", "thirdArea");
testGridAreaCSSParsing("twoValueGridArea", "-1", "span 1");
+ testGridAreaCSSParsing("twoValueIdentGridArea", "firstArea", "secondArea", "firstArea", "secondArea");
testGridAreaCSSParsing("threeValueGridArea", "span 1", "10", "-1");
testGridAreaCSSParsing("fourValueGridArea", "-5", "span 5", "span 8", "9");
+ testGridAreaCSSParsing("fourValueMixedGridArea", "firstArea", "span 1", "nonExistent", "1 foobar");
debug("");
debug("Test getting and setting grid-area set through JS");
« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-item-area-get-set-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698