Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: Source/core/rendering/RenderGrid.cpp

Issue 22215002: Allow grid positions to be named grid areas (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/resolver/StyleBuilderCustom.cpp ('k') | Source/core/rendering/style/GridPosition.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderGrid.cpp
diff --git a/Source/core/rendering/RenderGrid.cpp b/Source/core/rendering/RenderGrid.cpp
index 041dd4e7840859a44fda6a7a99b5376e4ed20b48..3a9e0a728995d5f6299b9e17e1de1a1cefc964eb 100644
--- a/Source/core/rendering/RenderGrid.cpp
+++ b/Source/core/rendering/RenderGrid.cpp
@@ -996,12 +996,12 @@ size_t RenderGrid::resolveGridPositionFromStyle(const GridPosition& position, Gr
return adjustGridPositionForSide(endOfTrack - resolvedPosition, side);
}
- case AutoPosition:
- // 'auto' depends on the opposite position for resolution (e.g. grid-row: auto / 1).
- ASSERT_NOT_REACHED();
+ case NamedGridAreaPosition:
+ // FIXME: Support resolving named grid area (crbug.com/258092).
return 0;
+ case AutoPosition:
case SpanPosition:
- // FIXME: Handle span positions (crbug.com/229713).
+ // 'auto' and span depend on the opposite position for resolution (e.g. grid-row: auto / 1 or grid-column: span 3 / "myHeader").
ASSERT_NOT_REACHED();
return 0;
}
« no previous file with comments | « Source/core/css/resolver/StyleBuilderCustom.cpp ('k') | Source/core/rendering/style/GridPosition.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698