Source/core/css/CSSComputedStyleDeclaration.cpp - Issue 22215002: Allow grid positions to be named grid areas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSComputedStyleDeclaration.cpp

Issue 22215002: Allow grid positions to be named grid areas (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSComputedStyleDeclaration.cpp

diff --git a/Source/core/css/CSSComputedStyleDeclaration.cpp b/Source/core/css/CSSComputedStyleDeclaration.cpp

index df1ea64c8c3c2e5ea0c398bd451032009c311a32..a64631ed2217f5390635c684512b5434b0eb21c6 100644

--- a/Source/core/css/CSSComputedStyleDeclaration.cpp

+++ b/Source/core/css/CSSComputedStyleDeclaration.cpp

@@ -1072,6 +1072,9 @@ static PassRefPtr<CSSValue> valueForGridPosition(const GridPosition& position)

if (position.isAuto())

return cssValuePool().createIdentifierValue(CSSValueAuto);

+ if (position.isNamedGridArea())

+ return cssValuePool().createValue(position.namedGridLine(), CSSPrimitiveValue::CSS_STRING);

RefPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();

if (position.isSpan()) {

list->append(cssValuePool().createIdentifierValue(CSSValueSpan));