Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2061823003: media: Drop "media::" in media/gpu (Closed)

Created:
4 years, 6 months ago by xhwang
Modified:
4 years, 6 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Drop "media::" in media/gpu Now media/gpu is moved to media namespace, there's no need to use media:: anymore. BUG=586386 Committed: https://crrev.com/60f96676bc512b3a785893bfd03e3ceb4d825be9 Cr-Commit-Position: refs/heads/master@{#399790}

Patch Set 1 : s/media::// #

Patch Set 2 : git cl format #

Patch Set 3 : fix ipc #

Patch Set 4 : more fixes #

Total comments: 2

Patch Set 5 : media: Drop "media::" in media/gpu #

Patch Set 6 : indent #

Patch Set 7 : work around clang format by adding an empty line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1220 lines, -1357 lines) Patch
M media/gpu/android_copying_backing_strategy.h View 2 chunks +4 lines, -4 lines 0 comments Download
M media/gpu/android_copying_backing_strategy.cc View 1 4 chunks +4 lines, -5 lines 0 comments Download
M media/gpu/android_deferred_rendering_backing_strategy.h View 1 2 chunks +8 lines, -9 lines 0 comments Download
M media/gpu/android_deferred_rendering_backing_strategy.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M media/gpu/android_video_decode_accelerator.h View 1 15 chunks +29 lines, -33 lines 0 comments Download
M media/gpu/android_video_decode_accelerator.cc View 1 34 chunks +85 lines, -90 lines 0 comments Download
M media/gpu/android_video_decode_accelerator_unittest.cc View 1 5 chunks +9 lines, -10 lines 0 comments Download
M media/gpu/android_video_encode_accelerator.h View 1 2 3 2 chunks +12 lines, -16 lines 0 comments Download
M media/gpu/android_video_encode_accelerator.cc View 1 2 3 15 chunks +43 lines, -47 lines 0 comments Download
M media/gpu/avda_codec_image.h View 3 chunks +3 lines, -3 lines 0 comments Download
M media/gpu/avda_codec_image.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/gpu/avda_return_on_failure.h View 1 1 chunk +7 lines, -7 lines 0 comments Download
M media/gpu/avda_shared_state.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/gpu/avda_shared_state.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/gpu/avda_state_provider.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/gpu/dxva_picture_buffer_win.h View 4 chunks +5 lines, -5 lines 0 comments Download
M media/gpu/dxva_picture_buffer_win.cc View 1 4 chunks +4 lines, -5 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.h View 1 9 chunks +12 lines, -16 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 1 20 chunks +45 lines, -50 lines 0 comments Download
M media/gpu/fake_video_decode_accelerator.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M media/gpu/fake_video_decode_accelerator.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M media/gpu/generic_v4l2_device.cc View 1 2 chunks +4 lines, -6 lines 0 comments Download
M media/gpu/gpu_video_decode_accelerator_factory_impl.h View 2 chunks +9 lines, -9 lines 0 comments Download
M media/gpu/gpu_video_decode_accelerator_factory_impl.cc View 11 chunks +23 lines, -23 lines 0 comments Download
M media/gpu/h264_decoder.h View 10 chunks +18 lines, -18 lines 0 comments Download
M media/gpu/h264_decoder.cc View 1 2 3 4 5 6 25 chunks +46 lines, -47 lines 0 comments Download
M media/gpu/h264_dpb.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M media/gpu/h264_dpb.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/ipc/common/create_video_encoder_params.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/gpu/ipc/common/create_video_encoder_params.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/gpu/ipc/service/gpu_jpeg_decode_accelerator.h View 3 chunks +4 lines, -4 lines 0 comments Download
M media/gpu/ipc/service/gpu_jpeg_decode_accelerator.cc View 1 2 9 chunks +36 lines, -44 lines 0 comments Download
M media/gpu/ipc/service/gpu_video_decode_accelerator.h View 7 chunks +9 lines, -9 lines 0 comments Download
M media/gpu/ipc/service/gpu_video_decode_accelerator.cc View 1 10 chunks +21 lines, -22 lines 0 comments Download
M media/gpu/ipc/service/gpu_video_encode_accelerator.h View 5 chunks +14 lines, -14 lines 0 comments Download
M media/gpu/ipc/service/gpu_video_encode_accelerator.cc View 1 11 chunks +36 lines, -40 lines 0 comments Download
M media/gpu/ipc/service/media_channel.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/gpu/ipc/service/media_channel.cc View 1 3 chunks +6 lines, -7 lines 0 comments Download
M media/gpu/jpeg_decode_accelerator_unittest.cc View 1 2 3 4 6 chunks +24 lines, -35 lines 0 comments Download
M media/gpu/shared_memory_region.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M media/gpu/shared_memory_region.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M media/gpu/v4l2_device.h View 1 2 chunks +8 lines, -10 lines 0 comments Download
M media/gpu/v4l2_device.cc View 1 10 chunks +33 lines, -39 lines 0 comments Download
M media/gpu/v4l2_image_processor.h View 5 chunks +7 lines, -7 lines 0 comments Download
M media/gpu/v4l2_image_processor.cc View 1 5 chunks +9 lines, -10 lines 0 comments Download
M media/gpu/v4l2_jpeg_decode_accelerator.h View 3 chunks +7 lines, -7 lines 0 comments Download
M media/gpu/v4l2_jpeg_decode_accelerator.cc View 10 chunks +23 lines, -23 lines 0 comments Download
M media/gpu/v4l2_slice_video_decode_accelerator.h View 1 6 chunks +8 lines, -11 lines 0 comments Download
M media/gpu/v4l2_slice_video_decode_accelerator.cc View 1 19 chunks +29 lines, -30 lines 0 comments Download
M media/gpu/v4l2_video_decode_accelerator.h View 1 8 chunks +12 lines, -14 lines 0 comments Download
M media/gpu/v4l2_video_decode_accelerator.cc View 1 16 chunks +44 lines, -50 lines 0 comments Download
M media/gpu/v4l2_video_encode_accelerator.h View 1 7 chunks +16 lines, -18 lines 0 comments Download
M media/gpu/v4l2_video_encode_accelerator.cc View 1 16 chunks +33 lines, -37 lines 0 comments Download
M media/gpu/vaapi_jpeg_decode_accelerator.h View 3 chunks +8 lines, -8 lines 0 comments Download
M media/gpu/vaapi_jpeg_decode_accelerator.cc View 6 chunks +13 lines, -13 lines 0 comments Download
M media/gpu/vaapi_jpeg_decoder.h View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download
M media/gpu/vaapi_jpeg_decoder.cc View 1 2 3 8 chunks +12 lines, -12 lines 0 comments Download
M media/gpu/vaapi_jpeg_decoder_unittest.cc View 1 2 3 5 chunks +14 lines, -16 lines 0 comments Download
M media/gpu/vaapi_video_decode_accelerator.h View 1 4 chunks +6 lines, -9 lines 0 comments Download
M media/gpu/vaapi_video_decode_accelerator.cc View 1 19 chunks +40 lines, -44 lines 0 comments Download
M media/gpu/vaapi_video_encode_accelerator.h View 1 5 chunks +14 lines, -16 lines 0 comments Download
M media/gpu/vaapi_video_encode_accelerator.cc View 1 18 chunks +38 lines, -44 lines 0 comments Download
M media/gpu/vaapi_wrapper.h View 1 3 chunks +5 lines, -7 lines 0 comments Download
M media/gpu/vaapi_wrapper.cc View 1 10 chunks +20 lines, -23 lines 0 comments Download
M media/gpu/video_decode_accelerator_unittest.cc View 1 2 3 22 chunks +38 lines, -42 lines 0 comments Download
M media/gpu/video_encode_accelerator_unittest.cc View 1 2 3 30 chunks +108 lines, -119 lines 0 comments Download
M media/gpu/vp8_decoder.h View 3 chunks +4 lines, -4 lines 0 comments Download
M media/gpu/vp8_decoder.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M media/gpu/vp9_decoder.h View 4 chunks +5 lines, -5 lines 0 comments Download
M media/gpu/vp9_decoder.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M media/gpu/vp9_picture.h View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/vt_video_decode_accelerator_mac.h View 1 8 chunks +10 lines, -11 lines 0 comments Download
M media/gpu/vt_video_decode_accelerator_mac.cc View 1 15 chunks +41 lines, -43 lines 0 comments Download
M media/gpu/vt_video_encode_accelerator_mac.h View 1 3 chunks +9 lines, -11 lines 0 comments Download
M media/gpu/vt_video_encode_accelerator_mac.cc View 1 15 chunks +30 lines, -34 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
xhwang
clean-up CL that should be trivial to review... PTAL
4 years, 6 months ago (2016-06-13 23:18:50 UTC) #6
xhwang
dcheng: Please OWNERS review trivial change in media/gpu/ipc/common/create_video_encoder_params.*
4 years, 6 months ago (2016-06-13 23:20:14 UTC) #8
Pawel Osciak
https://chromiumcodereview.appspot.com/2061823003/diff/140001/media/gpu/h264_decoder.cc File media/gpu/h264_decoder.cc (right): https://chromiumcodereview.appspot.com/2061823003/diff/140001/media/gpu/h264_decoder.cc#newcode1329 media/gpu/h264_decoder.cc:1329: case H264NALU::kIDRSlice: { Should indent be two spaces to ...
4 years, 6 months ago (2016-06-14 01:25:49 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061823003/160001
4 years, 6 months ago (2016-06-14 01:36:40 UTC) #12
xhwang
PTAL again https://chromiumcodereview.appspot.com/2061823003/diff/140001/media/gpu/h264_decoder.cc File media/gpu/h264_decoder.cc (right): https://chromiumcodereview.appspot.com/2061823003/diff/140001/media/gpu/h264_decoder.cc#newcode1329 media/gpu/h264_decoder.cc:1329: case H264NALU::kIDRSlice: { On 2016/06/14 01:25:49, Pawel ...
4 years, 6 months ago (2016-06-14 02:00:21 UTC) #13
dcheng
rs lgtm for ipc changes
4 years, 6 months ago (2016-06-14 04:30:50 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061823003/200001
4 years, 6 months ago (2016-06-14 04:59:33 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/238573)
4 years, 6 months ago (2016-06-14 07:11:27 UTC) #18
sandersd (OOO until July 31)
lgtm
4 years, 6 months ago (2016-06-14 19:12:40 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061823003/200001
4 years, 6 months ago (2016-06-14 19:30:21 UTC) #22
commit-bot: I haz the power
Committed patchset #7 (id:200001)
4 years, 6 months ago (2016-06-14 21:48:05 UTC) #23
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 21:48:15 UTC) #24
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 21:50:03 UTC) #26
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/60f96676bc512b3a785893bfd03e3ceb4d825be9
Cr-Commit-Position: refs/heads/master@{#399790}

Powered by Google App Engine
This is Rietveld 408576698