Issue 2047643003: DO NOT SUBMIT. Implement an XPCService for notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2047643003: DO NOT SUBMIT. Implement an XPCService for notifications.

Created:
4 years, 6 months ago by Miguel Garcia

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, oshima+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

DO NOT SUBMIT. Implement an XPCService for notifications. patch from issue 1953573002 at patchset 20001 (http://crrev.com/1953573002#ps20001) BUG=

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Merge to use AlertNotificationService #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+487 lines, -17 lines)			Patch
M	build/config/mac/rules.gni	View	1 2	3 chunks	+12 lines, -2 lines	0 comments	Download
M	build/config/mac/write_pkg_info.py	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/BUILD.gn	View	1 2	3 chunks	+15 lines, -1 line	0 comments	Download
M	chrome/app/theme/chromium/BRANDING	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/notifications/notification_platform_bridge_mac.h	View	1 2	2 chunks	+17 lines, -1 line	0 comments	Download
M	chrome/browser/notifications/notification_platform_bridge_mac.mm	View	1 2	5 chunks	+113 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/notifications/BUILD.gn	View	1 2	1 chunk	+30 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/cocoa/notifications/alert_notification_service.h	View	1 2	1 chunk	+17 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/cocoa/notifications/alert_notification_service.mm	View	1 2	1 chunk	+27 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
A	chrome/browser/ui/cocoa/notifications/notification_common.h	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/notifications/notification_common.gyp	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
A	chrome/browser/ui/cocoa/notifications/notification_common.mm	View		1 chunk	+20 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/cocoa/notifications/notification_delivery.h	View	1 2	1 chunk	+30 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/notifications/notification_response_builder_mac.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
A	chrome/browser/ui/cocoa/notifications/notification_service_delegate.h	View	1 2	1 chunk	+28 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/cocoa/notifications/notification_service_delegate.mm	View	1 2	1 chunk	+60 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/cocoa/notifications/xpc-Info.plist	View	1 2	1 chunk	+33 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/cocoa/notifications/xpc_service_main.mm	View	1 2	1 chunk	+33 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm	View		2 chunks	+27 lines, -0 lines	0 comments	Download