build/config/mac/write_pkg_info.py - Issue 2047643003: DO NOT SUBMIT. Implement an XPCService for notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/mac/write_pkg_info.py

Issue 2047643003: DO NOT SUBMIT. Implement an XPCService for notifications. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge to use AlertNotificationService Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/mac/write_pkg_info.py

diff --git a/build/config/mac/write_pkg_info.py b/build/config/mac/write_pkg_info.py

index b03e77928059d67cd8e20a82536faad81cc1847e..4812d82acb4cdd289fb45d9329b1e9700094076f 100644

--- a/build/config/mac/write_pkg_info.py

+++ b/build/config/mac/write_pkg_info.py

@@ -26,9 +26,9 @@ def Main():

plist = plistlib.readPlist(args.plist)

package_type = plist['CFBundlePackageType']

- if package_type != 'APPL':

- raise ValueError('Expected CFBundlePackageType to be %s, got %s' % \

- ('AAPL', package_type))

+ #if package_type != 'APPL':

+ # raise ValueError('Expected CFBundlePackageType to be %s, got %s' % \

+ # ('AAPL', package_type))

# The format of PkgInfo is eight characters, representing the bundle type

# and bundle signature, each four characters. If that is missing, four

« no previous file with comments | « build/config/mac/rules.gni ('k') | chrome/BUILD.gn » ('j') | no next file with comments »