Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3962)

Unified Diff: chrome/BUILD.gn

Issue 2047643003: DO NOT SUBMIT. Implement an XPCService for notifications. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge to use AlertNotificationService Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/mac/write_pkg_info.py ('k') | chrome/app/theme/chromium/BRANDING » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 1c26c3f29012af6f22a4709c98c11ea97376a6b7..eb01af5ca2e3767ce9a8a15723b4721d627208b8 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -444,6 +444,20 @@ if (is_win) {
}
}
+ bundle_data("chrome_framework_services") {
+ sources = [
+ "$root_out_dir/AlertNotificationService.xpc",
+ ]
+
+ outputs = [
+ "{{bundle_root_dir}}/XPCServices/{{source_file_part}}",
+ ]
+
+ public_deps = [
+ "//chrome/browser/ui/cocoa/notifications:alert_notification_xpc_service",
+ ]
+ }
+
tweak_info_plist("chrome_app_plist") {
info_plist = "app/app-Info.plist"
_keystone_arg = "0"
@@ -781,7 +795,6 @@ if (is_win) {
group("chrome_framework_plugins") {
}
}
-
if (is_chrome_branded) {
bundle_data("flash_player_plugin") {
sources = [
@@ -956,6 +969,7 @@ if (is_win) {
":chrome_framework_locales",
":chrome_framework_plugins",
":chrome_framework_resources",
+ ":chrome_framework_services",
":flash_player_plugin",
":widevine_cdm_library",
"//build/config/sanitizers:deps",
« no previous file with comments | « build/config/mac/write_pkg_info.py ('k') | chrome/app/theme/chromium/BRANDING » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698