chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm - Issue 2047643003: DO NOT SUBMIT. Implement an XPCService for notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm

Issue 2047643003: DO NOT SUBMIT. Implement an XPCService for notifications. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge to use AlertNotificationService Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm

diff --git a/chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm b/chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm

index 6bd715d014c4ea9f299e191168c25cf95fabd5e6..ed5681d577f97ea9a3340205e1ee9b5b43517e6d 100644

--- a/chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm

+++ b/chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm

@@ -123,9 +123,10 @@ NSString* const kNotificationSettingsButtonTag = @"settingsButton";

base::scoped_nsobject<NSUserNotification> toast(

[[NSUserNotification alloc] init]);

[toast setTitle:[notificationData_ objectForKey:kNotificationTitle]];

- [toast setSubtitle:[notificationData_ objectForKey:kNotificationSubTitle]];

[toast setInformativeText:[notificationData_

- objectForKey:kNotificationInformativeText]];

+ objectForKey:kNotificationSubTitle]];

+ [toast setSubtitle:[notificationData_

+ objectForKey:kNotificationInformativeText]];

// Icon

if ([notificationData_ objectForKey:kNotificationImage]) {