Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18182009: WaveTable name has changed to PeriodicWave (Closed)

Created:
7 years, 5 months ago by Chris Rogers
Modified:
7 years, 5 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

WaveTable name has changed to PeriodicWave See related W3C Web Audio bug and spec change: https://www.w3.org/Bugs/Public/show_bug.cgi?id=19561 https://dvcs.w3.org/hg/audio/rev/7c4a40a9bb57 Also see similar WebKit patch: https://bugs.webkit.org/show_bug.cgi?id=117748 BUG=none TEST=layout tests changed and pass Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153359

Patch Set 1 #

Patch Set 2 : fix global constructors test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -532 lines) Patch
M LayoutTests/webaudio/oscillator-basic.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/webaudio/oscillator-basic-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/webaudio/oscillator-custom.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/webaudio/resources/oscillator-testing.js View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/modules/modules.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webaudio/AudioContext.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/AudioContext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/webaudio/AudioContext.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/OscillatorNode.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/modules/webaudio/OscillatorNode.cpp View 11 chunks +34 lines, -34 lines 0 comments Download
M Source/modules/webaudio/OscillatorNode.idl View 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/webaudio/PeriodicWave.h View 3 chunks +16 lines, -16 lines 0 comments Download
A + Source/modules/webaudio/PeriodicWave.cpp View 6 chunks +43 lines, -43 lines 0 comments Download
A + Source/modules/webaudio/PeriodicWave.idl View 1 chunk +2 lines, -2 lines 0 comments Download
D Source/modules/webaudio/WaveTable.h View 1 chunk +0 lines, -98 lines 0 comments Download
D Source/modules/webaudio/WaveTable.cpp View 1 chunk +0 lines, -284 lines 0 comments Download
D Source/modules/webaudio/WaveTable.idl View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Chris Rogers
7 years, 5 months ago (2013-06-28 21:33:30 UTC) #1
Ken Russell (switch to Gerrit)
lgtm
7 years, 5 months ago (2013-07-01 11:31:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/crogers@google.com/18182009/5001
7 years, 5 months ago (2013-07-01 16:38:46 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-01 18:00:25 UTC) #4
Message was sent while issue was closed. 
Change committed as 153359

Powered by Google App Engine
This is Rietveld 408576698