Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Linux fixes, Part 3 of N

BUG=110610
TBR=darin

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203626

[Ryan Sleevi, 2013-06-01 01:31:21]

TBR

[commit-bot: I haz the power, 2013-06-01 01:31:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/16296002/1

[commit-bot: I haz the power, 2013-06-01 01:31:51]

Failed to apply patch for chrome/browser/profiles/profile_impl.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/profiles/profile_impl.cc
  Hunk #1 succeeded at 251 (offset 2 lines).
  Hunk #2 succeeded at 264 (offset 2 lines).
  Hunk #3 succeeded at 397 (offset 3 lines).
  Hunk #4 succeeded at 460 (offset 4 lines).
  Hunk #5 succeeded at 640 (offset 7 lines).
  Hunk #6 FAILED at 697.
  Hunk #7 succeeded at 886 (offset 12 lines).
  Hunk #8 succeeded at 927 (offset 12 lines).
  1 out of 8 hunks FAILED -- saving rejects to file
chrome/browser/profiles/profile_impl.cc.rej

Patch:       chrome/browser/profiles/profile_impl.cc
Index: chrome/browser/profiles/profile_impl.cc
diff --git a/chrome/browser/profiles/profile_impl.cc
b/chrome/browser/profiles/profile_impl.cc
index
6b8fa17a0ac89e8ed8edf00d2aaffffc06d552b9..b171efc21a4d09bd6443884ebe2aad3962ac59bb
100644
--- a/chrome/browser/profiles/profile_impl.cc
+++ b/chrome/browser/profiles/profile_impl.cc
@@ -249,7 +249,7 @@ Profile* Profile::CreateProfile(const base::FilePath& path,
                                           BrowserThread::GetBlockingPool());
   if (create_mode == CREATE_MODE_ASYNCHRONOUS) {
     DCHECK(delegate);
-    CreateProfileDirectory(sequenced_task_runner, path);
+    CreateProfileDirectory(sequenced_task_runner.get(), path);
   } else if (create_mode == CREATE_MODE_SYNCHRONOUS) {
     if (!file_util::PathExists(path)) {
       // TODO(tc): http://b/1094718 Bad things happen if we can't write to the
@@ -262,7 +262,8 @@ Profile* Profile::CreateProfile(const base::FilePath& path,
     NOTREACHED();
   }
 
-  return new ProfileImpl(path, delegate, create_mode, sequenced_task_runner);
+  return new ProfileImpl(
+      path, delegate, create_mode, sequenced_task_runner.get());
 }
 
 // static
@@ -393,7 +394,7 @@ ProfileImpl::ProfileImpl(
          create_mode == CREATE_MODE_SYNCHRONOUS);
   bool async_prefs = create_mode == CREATE_MODE_ASYNCHRONOUS;
 
-  chrome::RegisterUserPrefs(pref_registry_);
+  chrome::RegisterUserPrefs(pref_registry_.get());
 
   {
     // On startup, preference loading is always synchronous so a scoped timer
@@ -455,7 +456,7 @@ void ProfileImpl::DoFinalInit() {
   scoped_refptr<base::SequencedTaskRunner> sequenced_task_runner =
       JsonPrefStore::GetTaskRunnerForFile(base_cache_path_,
                                           BrowserThread::GetBlockingPool());
-  CreateProfileDirectory(sequenced_task_runner, base_cache_path_);
+  CreateProfileDirectory(sequenced_task_runner.get(), base_cache_path_);
 
   // Now that the profile is hooked up to receive pref change notifications to
   // kGoogleServicesUsername, initialize components that depend on it to
reflect
@@ -632,13 +633,13 @@ ProfileImpl::~ProfileImpl() {
  
BrowserContextDependencyManager::GetInstance()->DestroyBrowserContextServices(
       this);
 
-  if (top_sites_)
+  if (top_sites_.get())
     top_sites_->Shutdown();
 
   if (pref_proxy_config_tracker_)
     pref_proxy_config_tracker_->DetachFromPrefService();
 
-  if (host_content_settings_map_)
+  if (host_content_settings_map_.get())
     host_content_settings_map_->ShutdownOnUIThread();
 
   // This causes the Preferences file to be written to disk.
@@ -696,7 +697,7 @@ ExtensionService* ProfileImpl::GetExtensionService() {
 
 ExtensionSpecialStoragePolicy*
     ProfileImpl::GetExtensionSpecialStoragePolicy() {
-  if (!extension_special_storage_policy_) {
+  if (!extension_special_storage_policy_.get()) {
     extension_special_storage_policy_ = new ExtensionSpecialStoragePolicy(
         CookieSettings::Factory::GetForProfile(this));
   }
@@ -873,7 +874,7 @@ net::SSLConfigService* ProfileImpl::GetSSLConfigService() {
 }
 
 HostContentSettingsMap* ProfileImpl::GetHostContentSettingsMap() {
-  if (!host_content_settings_map_) {
+  if (!host_content_settings_map_.get()) {
     host_content_settings_map_ = new HostContentSettingsMap(GetPrefs(), false);
   }
   return host_content_settings_map_.get();
@@ -914,15 +915,15 @@ Time ProfileImpl::GetStartTime() const {
 }
 
 history::TopSites* ProfileImpl::GetTopSites() {
-  if (!top_sites_) {
+  if (!top_sites_.get()) {
     top_sites_ = history::TopSites::Create(
         this, GetPath().Append(chrome::kTopSitesFilename));
   }
-  return top_sites_;
+  return top_sites_.get();
 }
 
 history::TopSites* ProfileImpl::GetTopSitesWithoutCreating() {
-  return top_sites_;
+  return top_sites_.get();
 }
 
 void ProfileImpl::OnDefaultZoomLevelChanged() {

[commit-bot: I haz the power, 2013-06-01 02:03:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/16296002/5001

[commit-bot: I haz the power, 2013-06-02 21:16:04]

Change committed as 203626