chrome/browser/password_manager/password_store.cc - Issue 16296002: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store.cc

Issue 16296002: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager_unittest.cc ('k') | chrome/browser/password_manager/password_store_default_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store.cc

diff --git a/chrome/browser/password_manager/password_store.cc b/chrome/browser/password_manager/password_store.cc

index f85367c316b6822c294bfa60dcc9a5d46c2d6c07..87e062b82f3e2dd20ef2185260164c9336806c90 100644

--- a/chrome/browser/password_manager/password_store.cc

+++ b/chrome/browser/password_manager/password_store.cc

@@ -199,7 +199,7 @@ CancelableRequestProvider::Handle PasswordStore::Schedule(

NewGetLoginsRequest(

base::Bind(&PasswordStoreConsumer::OnPasswordStoreRequestDone,

base::Unretained(consumer))));

- AddRequest(request, consumer->cancelable_consumer());

+ AddRequest(request.get(), consumer->cancelable_consumer());

ScheduleTask(base::Bind(func, this, request));

return request->handle();

}

@@ -215,7 +215,7 @@ CancelableRequestProvider::Handle PasswordStore::Schedule(

base::Bind(&PasswordStoreConsumer::OnPasswordStoreRequestDone,

base::Unretained(consumer))));

request->set_ignore_logins_cutoff(ignore_logins_cutoff);

- AddRequest(request, consumer->cancelable_consumer());

+ AddRequest(request.get(), consumer->cancelable_consumer());

ScheduleTask(base::Bind(func, this, request, form));

return request->handle();

}