Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: chrome/browser/password_manager/password_store.cc

Issue 16296002: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/password_store.h" 5 #include "chrome/browser/password_manager/password_store.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/message_loop/message_loop_proxy.h" 10 #include "base/message_loop/message_loop_proxy.h"
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 } 192 }
193 193
194 template<typename BackendFunc> 194 template<typename BackendFunc>
195 CancelableRequestProvider::Handle PasswordStore::Schedule( 195 CancelableRequestProvider::Handle PasswordStore::Schedule(
196 BackendFunc func, 196 BackendFunc func,
197 PasswordStoreConsumer* consumer) { 197 PasswordStoreConsumer* consumer) {
198 scoped_refptr<GetLoginsRequest> request( 198 scoped_refptr<GetLoginsRequest> request(
199 NewGetLoginsRequest( 199 NewGetLoginsRequest(
200 base::Bind(&PasswordStoreConsumer::OnPasswordStoreRequestDone, 200 base::Bind(&PasswordStoreConsumer::OnPasswordStoreRequestDone,
201 base::Unretained(consumer)))); 201 base::Unretained(consumer))));
202 AddRequest(request, consumer->cancelable_consumer()); 202 AddRequest(request.get(), consumer->cancelable_consumer());
203 ScheduleTask(base::Bind(func, this, request)); 203 ScheduleTask(base::Bind(func, this, request));
204 return request->handle(); 204 return request->handle();
205 } 205 }
206 206
207 template<typename BackendFunc> 207 template<typename BackendFunc>
208 CancelableRequestProvider::Handle PasswordStore::Schedule( 208 CancelableRequestProvider::Handle PasswordStore::Schedule(
209 BackendFunc func, 209 BackendFunc func,
210 PasswordStoreConsumer* consumer, 210 PasswordStoreConsumer* consumer,
211 const PasswordForm& form, 211 const PasswordForm& form,
212 const base::Time& ignore_logins_cutoff) { 212 const base::Time& ignore_logins_cutoff) {
213 scoped_refptr<GetLoginsRequest> request( 213 scoped_refptr<GetLoginsRequest> request(
214 NewGetLoginsRequest( 214 NewGetLoginsRequest(
215 base::Bind(&PasswordStoreConsumer::OnPasswordStoreRequestDone, 215 base::Bind(&PasswordStoreConsumer::OnPasswordStoreRequestDone,
216 base::Unretained(consumer)))); 216 base::Unretained(consumer))));
217 request->set_ignore_logins_cutoff(ignore_logins_cutoff); 217 request->set_ignore_logins_cutoff(ignore_logins_cutoff);
218 AddRequest(request, consumer->cancelable_consumer()); 218 AddRequest(request.get(), consumer->cancelable_consumer());
219 ScheduleTask(base::Bind(func, this, request, form)); 219 ScheduleTask(base::Bind(func, this, request, form));
220 return request->handle(); 220 return request->handle();
221 } 221 }
222 222
223 void PasswordStore::WrapModificationTask(base::Closure task) { 223 void PasswordStore::WrapModificationTask(base::Closure task) {
224 #if !defined(OS_MACOSX) 224 #if !defined(OS_MACOSX)
225 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB)); 225 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
226 #endif // !defined(OS_MACOSX) 226 #endif // !defined(OS_MACOSX)
227 task.Run(); 227 task.Run();
228 PostNotifyLoginsChanged(); 228 PostNotifyLoginsChanged();
229 } 229 }
230 230
231 void PasswordStore::PostNotifyLoginsChanged() { 231 void PasswordStore::PostNotifyLoginsChanged() {
232 #if !defined(OS_MACOSX) 232 #if !defined(OS_MACOSX)
233 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB)); 233 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
234 #endif // !defined(OS_MACOSX) 234 #endif // !defined(OS_MACOSX)
235 BrowserThread::PostTask( 235 BrowserThread::PostTask(
236 BrowserThread::UI, FROM_HERE, 236 BrowserThread::UI, FROM_HERE,
237 base::Bind(&PasswordStore::NotifyLoginsChanged, this)); 237 base::Bind(&PasswordStore::NotifyLoginsChanged, this));
238 } 238 }
239 239
240 void PasswordStore::NotifyLoginsChanged() { 240 void PasswordStore::NotifyLoginsChanged() {
241 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 241 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
242 FOR_EACH_OBSERVER(Observer, observers_, OnLoginsChanged()); 242 FOR_EACH_OBSERVER(Observer, observers_, OnLoginsChanged());
243 } 243 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698