Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

chrome/browser/history/history_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The history system runs on a background thread so that potentially slow
 // database operations don't delay the browser. This backend processing is
 // represented by HistoryBackend. The HistoryService's job is to dispatch to
 // that thread.
 //
 // Main thread                       History thread
@@ skipping 240 matching lines @@
   // soon, so they will either listen for notifications or just retry this call
   // later.  If we've purged the backend, we haven't necessarily restarted it
   // loading by now, so we need to trigger the load in order to maintain that
   // expectation.
   LoadBackendIfNecessary();
   return backend_loaded_;
 }
 
 void HistoryService::UnloadBackend() {
   DCHECK(thread_checker_.CalledOnValidThread());
-  if (!history_backend_)
+  if (!history_backend_.get())
     return;  // Already unloaded.
 
   // Get rid of the in-memory backend.
   in_memory_backend_.reset();
 
   // Give the InMemoryURLIndex a chance to shutdown.
   if (in_memory_url_index_)
     in_memory_url_index_->ShutDown();
 
   // The backend's destructor must run on the history thread since it is not
@@ skipping 784 matching lines @@
 syncer::SyncError HistoryService::ProcessLocalDeleteDirective(
     const sync_pb::HistoryDeleteDirectiveSpecifics& delete_directive) {
   DCHECK(thread_checker_.CalledOnValidThread());
   return delete_directive_handler_.ProcessLocalDeleteDirective(
       delete_directive);
 }
 
 void HistoryService::SetInMemoryBackend(int backend_id,
     history::InMemoryHistoryBackend* mem_backend) {
   DCHECK(thread_checker_.CalledOnValidThread());
-  if (!history_backend_ || current_backend_id_ != backend_id) {
+  if (!history_backend_.get() || current_backend_id_ != backend_id) {
     DVLOG(1) << "Message from obsolete backend";
     // Cleaning up the memory backend.
     delete mem_backend;
     return;
   }
   DCHECK(!in_memory_backend_) << "Setting mem DB twice";
   in_memory_backend_.reset(mem_backend);
 
   // The database requires additional initialization once we own it.
   in_memory_backend_->AttachToHistoryService(profile_);
 }
 
 void HistoryService::NotifyProfileError(int backend_id,
                                         sql::InitStatus init_status) {
   DCHECK(thread_checker_.CalledOnValidThread());
-  if (!history_backend_ || current_backend_id_ != backend_id) {
+  if (!history_backend_.get() || current_backend_id_ != backend_id) {
     DVLOG(1) << "Message from obsolete backend";
     return;
   }
   ShowProfileErrorDialog(
       (init_status == sql::INIT_FAILURE) ?
       IDS_COULDNT_OPEN_PROFILE_ERROR : IDS_PROFILE_TOO_NEW_ERROR);
 }
 
 void HistoryService::DeleteURL(const GURL& url) {
   DCHECK(thread_checker_.CalledOnValidThread());
   // We will update the visited links when we observe the delete notifications.
   ScheduleAndForget(PRIORITY_NORMAL, &HistoryBackend::DeleteURL, url);
 }
 
 void HistoryService::DeleteURLsForTest(const std::vector<GURL>& urls) {
   DCHECK(thread_checker_.CalledOnValidThread());
   // We will update the visited links when we observe the delete
   // notifications.
   ScheduleAndForget(PRIORITY_NORMAL, &HistoryBackend::DeleteURLs, urls);
 }
 
 void HistoryService::ExpireHistoryBetween(
     const std::set<GURL>& restrict_urls,
     Time begin_time,
     Time end_time,
     const base::Closure& callback,
     CancelableTaskTracker* tracker) {
   DCHECK(thread_);
   DCHECK(thread_checker_.CalledOnValidThread());
-  DCHECK(history_backend_);
-  tracker->PostTaskAndReply(
-      thread_->message_loop_proxy(),
-      FROM_HERE,
-      base::Bind(&HistoryBackend::ExpireHistoryBetween,
-                 history_backend_, restrict_urls, begin_time, end_time),
-      callback);
+  DCHECK(history_backend_.get());
+  tracker->PostTaskAndReply(thread_->message_loop_proxy(),
+                            FROM_HERE,
+                            base::Bind(&HistoryBackend::ExpireHistoryBetween,
+                                       history_backend_,
+                                       restrict_urls,
+                                       begin_time,
+                                       end_time),
+                            callback);
 }
 
 void HistoryService::ExpireHistory(
     const std::vector<history::ExpireHistoryArgs>& expire_list,
     const base::Closure& callback,
     CancelableTaskTracker* tracker) {
   DCHECK(thread_);
   DCHECK(thread_checker_.CalledOnValidThread());
-  DCHECK(history_backend_);
+  DCHECK(history_backend_.get());
   tracker->PostTaskAndReply(
       thread_->message_loop_proxy(),
       FROM_HERE,
       base::Bind(&HistoryBackend::ExpireHistory, history_backend_, expire_list),
       callback);
 }
 
 void HistoryService::ExpireLocalAndRemoteHistoryBetween(
     const std::set<GURL>& restrict_urls,
     Time begin_time,
@@ skipping 46 matching lines @@
   // The details object just contains the pointer to the object that the
   // backend has allocated for us. The receiver of the notification will cast
   // this to the proper type.
   content::Details<history::HistoryDetails> det(details);
 
   content::NotificationService::current()->Notify(type, source, det);
 }
 
 void HistoryService::LoadBackendIfNecessary() {
   DCHECK(thread_checker_.CalledOnValidThread());
-  if (!thread_ || history_backend_)
+  if (!thread_ || history_backend_.get())
     return;  // Failed to init, or already started loading.
 
   ++current_backend_id_;
   scoped_refptr<HistoryBackend> backend(
       new HistoryBackend(history_dir_,
                          current_backend_id_,
                          new BackendDelegate(
                              weak_ptr_factory_.GetWeakPtr(),
                              base::ThreadTaskRunnerHandle::Get(),
                              profile_),
                          bookmark_service_));
   history_backend_.swap(backend);
 
   // There may not be a profile when unit testing.
   std::string languages;
   if (profile_) {
     PrefService* prefs = profile_->GetPrefs();
     languages = prefs->GetString(prefs::kAcceptLanguages);
   }
   ScheduleAndForget(PRIORITY_UI, &HistoryBackend::Init, languages, no_db_);
 }
 
 void HistoryService::OnDBLoaded(int backend_id) {
   DCHECK(thread_checker_.CalledOnValidThread());
-  if (!history_backend_ || current_backend_id_ != backend_id) {
+  if (!history_backend_.get() || current_backend_id_ != backend_id) {
     DVLOG(1) << "Message from obsolete backend";
     return;
   }
   backend_loaded_ = true;
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_HISTORY_LOADED,
       content::Source<Profile>(profile_),
       content::Details<HistoryService>(this));
   if (thread_ && profile_) {
     // We don't want to force creation of TopSites.
     history::TopSites* ts = profile_->GetTopSitesWithoutCreating();
     if (ts)
       ts->HistoryLoaded();
   }
 }
 
 bool HistoryService::GetRowForURL(const GURL& url, history::URLRow* url_row) {
   DCHECK(thread_checker_.CalledOnValidThread());
   history::URLDatabase* db = InMemoryDatabase();
   return db && (db->GetRowForURL(url, url_row) != 0);
 }
 
 void HistoryService::StartTopSitesMigration(int backend_id) {
   DCHECK(thread_checker_.CalledOnValidThread());
-  if (!history_backend_ || current_backend_id_ != backend_id) {
+  if (!history_backend_.get() || current_backend_id_ != backend_id) {
     DVLOG(1) << "Message from obsolete backend";
     return;
   }
   needs_top_sites_migration_ = true;
   if (thread_ && profile_) {
     // We don't want to force creation of TopSites.
     history::TopSites* ts = profile_->GetTopSitesWithoutCreating();
     if (ts)
       ts->MigrateFromHistory();
   }
@@ skipping 16 matching lines @@
   DCHECK(thread_checker_.CalledOnValidThread());
   visit_database_observers_.RemoveObserver(observer);
 }
 
 void HistoryService::NotifyVisitDBObserversOnAddVisit(
     const history::BriefVisitInfo& info) {
   DCHECK(thread_checker_.CalledOnValidThread());
   FOR_EACH_OBSERVER(history::VisitDatabaseObserver, visit_database_observers_,
                     OnAddVisit(info));
 }