Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5825)

Unified Diff: chrome/browser/password_manager/password_store_default_unittest.cc

Issue 16296002: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_default_unittest.cc
diff --git a/chrome/browser/password_manager/password_store_default_unittest.cc b/chrome/browser/password_manager/password_store_default_unittest.cc
index 825f2abf1c308b22b1412837545e3d29bcc92c98..69dfbe5ce7beeb444bf6dbf68aabe4a3b3c6ed67 100644
--- a/chrome/browser/password_manager/password_store_default_unittest.cc
+++ b/chrome/browser/password_manager/password_store_default_unittest.cc
@@ -209,18 +209,18 @@ TEST_F(PasswordStoreDefaultTest, Notifications) {
scoped_ptr<PasswordForm> form(CreatePasswordFormFromData(form_data));
scoped_refptr<DBThreadObserverHelper> helper = new DBThreadObserverHelper;
- helper->Init(store);
+ helper->Init(store.get());
const PasswordStoreChange expected_add_changes[] = {
PasswordStoreChange(PasswordStoreChange::ADD, *form),
};
- EXPECT_CALL(helper->observer(),
+ EXPECT_CALL(
+ helper->observer(),
Observe(int(chrome::NOTIFICATION_LOGINS_CHANGED),
- content::Source<PasswordStore>(store),
- Property(&content::Details<const PasswordStoreChangeList>::ptr,
- Pointee(ElementsAreArray(
- expected_add_changes)))));
+ content::Source<PasswordStore>(store.get()),
+ Property(&content::Details<const PasswordStoreChangeList>::ptr,
+ Pointee(ElementsAreArray(expected_add_changes)))));
// Adding a login should trigger a notification.
store->AddLogin(*form);
@@ -239,12 +239,12 @@ TEST_F(PasswordStoreDefaultTest, Notifications) {
PasswordStoreChange(PasswordStoreChange::UPDATE, *form),
};
- EXPECT_CALL(helper->observer(),
+ EXPECT_CALL(
+ helper->observer(),
Observe(int(chrome::NOTIFICATION_LOGINS_CHANGED),
- content::Source<PasswordStore>(store),
+ content::Source<PasswordStore>(store.get()),
Property(&content::Details<const PasswordStoreChangeList>::ptr,
- Pointee(ElementsAreArray(
- expected_update_changes)))));
+ Pointee(ElementsAreArray(expected_update_changes)))));
// Updating the login with the new password should trigger a notification.
store->UpdateLogin(*form);
@@ -258,12 +258,12 @@ TEST_F(PasswordStoreDefaultTest, Notifications) {
PasswordStoreChange(PasswordStoreChange::REMOVE, *form),
};
- EXPECT_CALL(helper->observer(),
+ EXPECT_CALL(
+ helper->observer(),
Observe(int(chrome::NOTIFICATION_LOGINS_CHANGED),
- content::Source<PasswordStore>(store),
+ content::Source<PasswordStore>(store.get()),
Property(&content::Details<const PasswordStoreChangeList>::ptr,
- Pointee(ElementsAreArray(
- expected_delete_changes)))));
+ Pointee(ElementsAreArray(expected_delete_changes)))));
// Deleting the login should trigger a notification.
store->RemoveLogin(*form);
« no previous file with comments | « chrome/browser/password_manager/password_store.cc ('k') | chrome/browser/password_manager/password_store_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698