Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12611030: Remove unused parameter to OnError() (Closed)

Created:
7 years, 9 months ago by jrummell
Modified:
7 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, sail+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove unused parameter to OnError() This change removes the error_code parameter to OnError() calls as the parameter is not used when ending up in AudioRendererHost. BUG=218641 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190087

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix nits + rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -127 lines) Patch
M content/browser/renderer_host/media/audio_input_renderer_host.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.cc View 1 2 chunks +6 lines, -9 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 1 2 chunks +7 lines, -6 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/web_contents_audio_input_stream.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/web_contents_audio_input_stream_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/speech/speech_recognizer.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/speech/speech_recognizer.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/speech/speech_recognizer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/android/opensles_input.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/android/opensles_output.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_input_controller.h View 3 chunks +3 lines, -3 lines 0 comments Download
M media/audio/audio_input_controller.cc View 4 chunks +7 lines, -9 lines 0 comments Download
M media/audio/audio_input_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/audio_input_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_io.h View 2 chunks +4 lines, -6 lines 0 comments Download
M media/audio/audio_low_latency_input_output_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/audio_output_controller.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M media/audio/audio_output_controller.cc View 1 3 chunks +6 lines, -10 lines 0 comments Download
M media/audio/audio_output_controller_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M media/audio/audio_output_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_proxy_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/audio_output_resampler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/audio/cras/cras_input.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/audio/cras/cras_input_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/cras/cras_output.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/audio/cras/cras_output_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/linux/alsa_input.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/linux/alsa_output.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/linux/alsa_output_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/mac/audio_input_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/mac/audio_low_latency_input_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/mac/audio_low_latency_input_mac_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/pulse/pulse_input.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/pulse/pulse_output.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M media/audio/simple_sources.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/simple_sources.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/simple_sources_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/virtual_audio_input_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_input_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_input_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/win/audio_low_latency_output_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_output_win_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/audio/win/audio_output_win_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/audio/win/audio_unified_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_unified_win_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/audio/win/wavein_input_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/waveout_output_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
jrummell
PTAL
7 years, 9 months ago (2013-03-21 00:33:28 UTC) #1
DaleCurtis
lgtm! Nice first change!
7 years, 9 months ago (2013-03-21 00:45:01 UTC) #2
scherkus (not reviewing)
lgtm w/ two nits https://codereview.chromium.org/12611030/diff/1/content/browser/renderer_host/media/audio_input_renderer_host.cc File content/browser/renderer_host/media/audio_input_renderer_host.cc (right): https://codereview.chromium.org/12611030/diff/1/content/browser/renderer_host/media/audio_input_renderer_host.cc#newcode96 content/browser/renderer_host/media/audio_input_renderer_host.cc:96: void AudioInputRendererHost::OnError( nit: this looks ...
7 years, 9 months ago (2013-03-21 17:37:23 UTC) #3
jrummell
Fix the nits + rebase https://codereview.chromium.org/12611030/diff/1/content/browser/renderer_host/media/audio_input_renderer_host.cc File content/browser/renderer_host/media/audio_input_renderer_host.cc (right): https://codereview.chromium.org/12611030/diff/1/content/browser/renderer_host/media/audio_input_renderer_host.cc#newcode96 content/browser/renderer_host/media/audio_input_renderer_host.cc:96: void AudioInputRendererHost::OnError( On 2013/03/21 ...
7 years, 9 months ago (2013-03-21 18:17:31 UTC) #4
jrummell
Adding tommi to review changes in content/browser/speech
7 years, 9 months ago (2013-03-21 20:01:41 UTC) #5
jrummell
tommi: changed to TBR
7 years, 9 months ago (2013-03-22 18:51:31 UTC) #6
tommi1
lgtm! nice
7 years, 9 months ago (2013-03-22 18:59:44 UTC) #7
tommi (sloooow) - chröme
lgtm
7 years, 9 months ago (2013-03-22 19:07:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrummell@chromium.org/12611030/5001
7 years, 9 months ago (2013-03-22 19:47:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrummell@chromium.org/12611030/5001
7 years, 9 months ago (2013-03-23 15:07:13 UTC) #10
commit-bot: I haz the power
7 years, 9 months ago (2013-03-23 21:46:51 UTC) #11
Message was sent while issue was closed. 
Change committed as 190087

Powered by Google App Engine
This is Rietveld 408576698