Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Unified Diff: media/audio/pulse/pulse_output.cc

Issue 12611030: Remove unused parameter to OnError() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nits + rebase Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/pulse/pulse_input.cc ('k') | media/audio/simple_sources.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/pulse/pulse_output.cc
diff --git a/media/audio/pulse/pulse_output.cc b/media/audio/pulse/pulse_output.cc
index 953c854c3bbe5345621264a15e394fa3ed95c446..1a4b275f2bb26477894870760881ca53c38c3f78 100644
--- a/media/audio/pulse/pulse_output.cc
+++ b/media/audio/pulse/pulse_output.cc
@@ -27,7 +27,7 @@ void PulseAudioOutputStream::ContextNotifyCallback(pa_context* c,
// should be thread safe.
if (c && stream->source_callback_ &&
pa_context_get_state(c) == PA_CONTEXT_FAILED) {
- stream->source_callback_->OnError(stream, pa_context_errno(c));
+ stream->source_callback_->OnError(stream);
}
pa_threaded_mainloop_signal(stream->pa_mainloop_, 0);
@@ -42,8 +42,7 @@ void PulseAudioOutputStream::StreamNotifyCallback(pa_stream* s, void* p_this) {
// should be thread safe.
if (s && stream->source_callback_ &&
pa_stream_get_state(s) == PA_STREAM_FAILED) {
- stream->source_callback_->OnError(
- stream, pa_context_errno(stream->pa_context_));
+ stream->source_callback_->OnError(stream);
}
pa_threaded_mainloop_signal(stream->pa_mainloop_, 0);
@@ -276,7 +275,7 @@ void PulseAudioOutputStream::FulfillWriteRequest(size_t requested_bytes) {
if (pa_stream_write(pa_stream_, buffer, bytes_to_fill, NULL, 0LL,
PA_SEEK_RELATIVE) < 0) {
if (source_callback_) {
- source_callback_->OnError(this, pa_context_errno(pa_context_));
+ source_callback_->OnError(this);
}
}
@@ -294,7 +293,7 @@ void PulseAudioOutputStream::Start(AudioSourceCallback* callback) {
// Ensure the context and stream are ready.
if (pa_context_get_state(pa_context_) != PA_CONTEXT_READY &&
pa_stream_get_state(pa_stream_) != PA_STREAM_READY) {
- callback->OnError(this, pa_context_errno(pa_context_));
+ callback->OnError(this);
return;
}
« no previous file with comments | « media/audio/pulse/pulse_input.cc ('k') | media/audio/simple_sources.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698