content/browser/renderer_host/media/web_contents_audio_input_stream.cc - Issue 12611030: Remove unused parameter to OnError()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/web_contents_audio_input_stream.cc

Issue 12611030: Remove unused parameter to OnError() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix nits + rebase Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/audio_renderer_host_unittest.cc ('k') | content/browser/renderer_host/media/web_contents_audio_input_stream_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/web_contents_audio_input_stream.cc

diff --git a/content/browser/renderer_host/media/web_contents_audio_input_stream.cc b/content/browser/renderer_host/media/web_contents_audio_input_stream.cc

index f01bc408bb1e13bb2f8330e62c477b77fb024c6d..beddcb874328f60e40c64119b3fabef5a9fcd715 100644

--- a/content/browser/renderer_host/media/web_contents_audio_input_stream.cc

+++ b/content/browser/renderer_host/media/web_contents_audio_input_stream.cc

@@ -204,8 +204,7 @@ void WebContentsAudioInputStream::Impl::ReportError() {

// TODO(miu): Need clean-up of AudioInputCallback interface in a future

// change, since its only implementation ignores the first argument entirely

- // and the values for the second argument are undefined.

- callback_->OnError(NULL, 0);

+ callback_->OnError(NULL);

}

void WebContentsAudioInputStream::Impl::StartMirroring() {