Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: media/audio/cras/cras_output.cc

Issue 12611030: Remove unused parameter to OnError() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nits + rebase Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/cras/cras_input_unittest.cc ('k') | media/audio/cras/cras_output_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/cras/cras_output.cc
diff --git a/media/audio/cras/cras_output.cc b/media/audio/cras/cras_output.cc
index 1995d96eb2cbbddb966f3ac7df576c4c9f15a0ca..9f59ea360159a8b13d9aaccf3703df78cf6369db 100644
--- a/media/audio/cras/cras_output.cc
+++ b/media/audio/cras/cras_output.cc
@@ -181,7 +181,7 @@ void CrasOutputStream::Start(AudioSourceCallback* callback) {
if (audio_format == NULL) {
LOG(WARNING) << "Error setting up audio parameters.";
TransitionTo(kInError);
- callback->OnError(this, -ENOMEM);
+ callback->OnError(this);
return;
}
cras_stream_params* stream_params = cras_client_stream_params_create(
@@ -198,7 +198,7 @@ void CrasOutputStream::Start(AudioSourceCallback* callback) {
if (stream_params == NULL) {
LOG(WARNING) << "Error setting up stream parameters.";
TransitionTo(kInError);
- callback->OnError(this, -ENOMEM);
+ callback->OnError(this);
cras_audio_format_destroy(audio_format);
return;
}
@@ -212,7 +212,7 @@ void CrasOutputStream::Start(AudioSourceCallback* callback) {
if (err < 0) {
LOG(WARNING) << "Failed to add the stream";
TransitionTo(kInError);
- callback->OnError(this, err);
+ callback->OnError(this);
cras_audio_format_destroy(audio_format);
cras_client_stream_params_destroy(stream_params);
return;
@@ -302,7 +302,7 @@ void CrasOutputStream::NotifyStreamError(int err) {
return; // Don't care about error if we aren't using it.
TransitionTo(kInError);
if (source_callback_)
- source_callback_->OnError(this, err);
+ source_callback_->OnError(this);
}
bool CrasOutputStream::CanTransitionTo(InternalState to) {
« no previous file with comments | « media/audio/cras/cras_input_unittest.cc ('k') | media/audio/cras/cras_output_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698