Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 12494005: Use client side arrays for GL_STREAM_DRAW attributes (Closed)

Created:
7 years, 9 months ago by greggman
Modified:
7 years, 9 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Use client side arrays for GL_STREAM_DRAW attributes Certain GPU/drivers are slow when using constantly changing vertex buffers. They also run out of memory as the pipeline the buffers so while a buffer is in used being drawn to they can't delete it immediately when you upload new data to the buffer. This is an attempt to work around that issue seemlessly by using client side arrays for buffers marked as GL_STREAM_DRAW BUG=178093 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186416

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+835 lines, -248 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 3 chunks +18 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 9 chunks +7 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager.h View 11 chunks +50 lines, -13 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager.cc View 4 chunks +77 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager_unittest.cc View 11 chunks +193 lines, -102 lines 0 comments Download
M gpu/command_buffer/service/context_group.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 5 chunks +16 lines, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 8 chunks +56 lines, -76 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 12 chunks +13 lines, -20 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h View 1 chunk +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/query_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/test_helper.h View 2 chunks +8 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/test_helper.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/vertex_attrib_manager.h View 4 chunks +22 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/vertex_attrib_manager.cc View 3 chunks +114 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/vertex_attrib_manager_unittest.cc View 6 chunks +17 lines, -6 lines 0 comments Download
A gpu/command_buffer/tests/gl_stream_draw_unittests.cc View 1 chunk +157 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_test_utils.h View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_test_utils.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M gpu/gpu.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
greggman
Hey Al, PTAL
7 years, 9 months ago (2013-03-06 00:18:59 UTC) #1
apatrick_chromium
lgtm
7 years, 9 months ago (2013-03-06 02:24:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/12494005/1
7 years, 9 months ago (2013-03-06 04:04:29 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=118807
7 years, 9 months ago (2013-03-06 05:15:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/12494005/1
7 years, 9 months ago (2013-03-06 05:37:58 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-06 13:06:52 UTC) #6
Message was sent while issue was closed.
Change committed as 186416

Powered by Google App Engine
This is Rietveld 408576698