Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Unified Diff: gpu/command_buffer/service/vertex_attrib_manager.h

Issue 12494005: Use client side arrays for GL_STREAM_DRAW attributes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/test_helper.cc ('k') | gpu/command_buffer/service/vertex_attrib_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/vertex_attrib_manager.h
diff --git a/gpu/command_buffer/service/vertex_attrib_manager.h b/gpu/command_buffer/service/vertex_attrib_manager.h
index 76c75c8aff2144baec95c1a6e5fd73c8b577a4a5..ddd29beb044ca2d4e46d3d743bb66d74e430ae86 100644
--- a/gpu/command_buffer/service/vertex_attrib_manager.h
+++ b/gpu/command_buffer/service/vertex_attrib_manager.h
@@ -17,6 +17,9 @@
namespace gpu {
namespace gles2 {
+class FeatureInfo;
+class GLES2Decoder;
+class Program;
class VertexArrayManager;
// Info about a Vertex Attribute. This is used to track what the user currently
@@ -75,6 +78,14 @@ class GPU_EXPORT VertexAttrib {
max_vertex_accessed;
}
+ bool is_client_side_array() const {
+ return is_client_side_array_;
+ }
+
+ void set_is_client_side_array(bool value) {
+ is_client_side_array_ = value;
+ }
+
private:
friend class VertexAttribManager;
@@ -139,6 +150,9 @@ class GPU_EXPORT VertexAttrib {
GLsizei divisor_;
+ // Will be true if this was assigned to a client side array.
+ bool is_client_side_array_;
+
// The buffer bound to this attribute.
scoped_refptr<Buffer> buffer_;
@@ -231,6 +245,14 @@ class GPU_EXPORT VertexAttribManager :
return vertex_attrib_infos_.size();
}
+ bool ValidateBindings(
+ const char* function_name,
+ GLES2Decoder* decoder,
+ FeatureInfo* feature_info,
+ Program* current_program,
+ GLuint max_vertex_accessed,
+ GLsizei primcount);
+
private:
friend class VertexArrayManager;
friend class VertexArrayManagerTest;
« no previous file with comments | « gpu/command_buffer/service/test_helper.cc ('k') | gpu/command_buffer/service/vertex_attrib_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698