Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2700)

Unified Diff: gpu/command_buffer/service/feature_info.cc

Issue 12494005: Use client side arrays for GL_STREAM_DRAW attributes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/feature_info.h ('k') | gpu/command_buffer/service/feature_info_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/feature_info.cc
diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc
index bde9f3e73af369e6961c93c1398f4515ac6de255..3a60942bcdb3f667789eca5a5ffde125e24ffd6f 100644
--- a/gpu/command_buffer/service/feature_info.cc
+++ b/gpu/command_buffer/service/feature_info.cc
@@ -94,6 +94,7 @@ FeatureInfo::Workarounds::Workarounds()
restore_scissor_on_fbo_change(false),
flush_on_context_switch(false),
delete_instead_of_resize_fbo(false),
+ use_client_side_arrays_for_stream_buffers(false),
max_texture_size(0),
max_cube_map_texture_size(0) {
}
@@ -168,6 +169,7 @@ void FeatureInfo::AddFeatures() {
bool is_mesa = false;
bool is_qualcomm = false;
bool is_imagination = false;
+ bool is_arm = false;
for (size_t ii = 0; ii < arraysize(string_ids); ++ii) {
const char* str = reinterpret_cast<const char*>(
glGetString(string_ids[ii]));
@@ -180,6 +182,7 @@ void FeatureInfo::AddFeatures() {
is_mesa |= string_set.Contains("mesa");
is_qualcomm |= string_set.Contains("qualcomm");
is_imagination |= string_set.Contains("imagination");
+ is_arm |= string_set.Contains("arm");
}
}
@@ -191,7 +194,6 @@ void FeatureInfo::AddFeatures() {
!CommandLine::ForCurrentProcess()->HasSwitch(
switches::kDisableShaderNameHashing);
-
bool npot_ok = false;
AddExtensionString("GL_ANGLE_translated_shader_source");
@@ -337,6 +339,19 @@ void FeatureInfo::AddFeatures() {
feature_flags_.native_vertex_array_object = true;
}
+ // If the driver doesn't like uploading lots of buffer data constantly
+ // work around it by using client side arrays.
+ if (is_arm || is_imagination) {
+ workarounds_.use_client_side_arrays_for_stream_buffers = true;
+ }
+
+ // If we're using client_side_arrays we have to emulate
+ // vertex array objects since vertex array objects do not work
+ // with client side arrays.
+ if (workarounds_.use_client_side_arrays_for_stream_buffers) {
+ feature_flags_.native_vertex_array_object = false;
+ }
+
if (extensions.Contains("GL_OES_element_index_uint") ||
gfx::HasDesktopGLFeatures()) {
AddExtensionString("GL_OES_element_index_uint");
« no previous file with comments | « gpu/command_buffer/service/feature_info.h ('k') | gpu/command_buffer/service/feature_info_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698