Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 12114034: Swap BrowserList::const_iterator for the multi-desktop aware BrowserIterator in many scenarios. (Closed)

Created:
7 years, 10 months ago by gab
Modified:
7 years, 10 months ago
CC:
chromium-reviews, pam+watch_chromium.org, dbeam+watch-ntp_chromium.org, vsevik, akalin, marja+watch_chromium.org, yoshiki+watch_chromium.org, kkania, yurys, Aaron Boodman, robertshield, tim (not reviewing), Raghu Simha, chromium-apps-reviews_chromium.org, haitaol1, estade+watch_chromium.org, pfeldman, pedrosimonetti+watch_chromium.org
Visibility:
Public.

Description

Swap BrowserList::const_iterator for the multi-desktop aware BrowserIterator in many scenarios. Some of these are trivial; some others will potentially require more thinking for the feature to be right (e.g., we might want "Continue where I left off" to be per-desktop, etc.), but at least they now work (i.e., do something) on multi-desktop environments. Clear candidates for separate desktop-specific iteration were left out in this CL as well as non-trivial swaps which I'll put in their own CL. This CL is making progress towards getting rid of BrowserList::const_iterator (non-multi-desktop aware) and removes BrowserList::iterator which was already no longer used. BUG=129187, 170753 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -132 lines) Patch
M chrome/browser/automation/automation_provider_observers.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/automation/automation_util.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 6 chunks +12 lines, -15 lines 0 comments Download
M chrome/browser/custom_home_pages_table_model.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/devtools/browser_list_tabcontents_provider.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 3 chunks +20 lines, -19 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/browser_event_router.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 4 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/lifetime/application_lifetime.cc View 5 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/managed_mode/managed_mode.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 5 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/sync/browser_synced_window_delegate.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/tabs/pinned_tab_codec.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/uma_browsing_activity_observer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/suggestions_combiner.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gab
Ben, please take a look and let me know if you agree with swapping all ...
7 years, 10 months ago (2013-01-31 20:57:42 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 10 months ago (2013-01-31 21:48:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/12114034/1
7 years, 10 months ago (2013-01-31 22:01:06 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 10 months ago (2013-01-31 22:10:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/12114034/1
7 years, 10 months ago (2013-01-31 22:12:42 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 05:59:17 UTC) #6
Message was sent while issue was closed.
Change committed as 180095

Powered by Google App Engine
This is Rietveld 408576698