Swap BrowserList::const_iterator for the multi-desktop aware BrowserIterator in many scenarios.

chrome/browser/ui/webui/ntp/suggestions_combiner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/ntp/suggestions_combiner.h"
 
 #include <algorithm>
 
 #include "base/values.h"
 #include "chrome/browser/extensions/api/discovery/suggested_links_registry.h"
 #include "chrome/browser/extensions/api/discovery/suggested_links_registry_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/browser_iterator.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/webui/ntp/suggestions_page_handler.h"
 #include "chrome/browser/ui/webui/ntp/suggestions_source.h"
 #include "chrome/browser/ui/webui/ntp/suggestions_source_discovery.h"
 #include "content/public/browser/web_contents.h"
 
 namespace {
 
 static const size_t kSuggestionsCount = 8;
 
@@ skipping 120 matching lines @@
   if (debug_enabled_) {
     std::string url_string;
     if (page_value->GetString("url", &url_string)) {
       GURL url(url_string);
       page_value->SetBoolean("already_open", IsUrlAlreadyOpen(url));
     }
   }
 }
 
 bool SuggestionsCombiner::IsUrlAlreadyOpen(const GURL &url) {
-  for (BrowserList::const_iterator it = BrowserList::begin();
-       it != BrowserList::end(); ++it) {
+  for (chrome::BrowserIterator it; !it.done(); it.Next()) {
     const Browser* browser = *it;
     if (browser->profile()->IsOffTheRecord() ||
         !browser->profile()->IsSameProfile(profile_))
       continue;
 
     for (int i = 0; i < browser->tab_strip_model()->count(); i++) {
       const content::WebContents* tab =
           browser->tab_strip_model()->GetWebContentsAt(i);
       if (tab->GetURL() == url)
         return true;
     }
   }
   return false;
 }