Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: chrome/browser/ui/sync/browser_synced_window_delegate.cc

Issue 12114034: Swap BrowserList::const_iterator for the multi-desktop aware BrowserIterator in many scenarios. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/browser_list.h ('k') | chrome/browser/ui/tabs/pinned_tab_codec.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/sync/browser_synced_window_delegate.h" 5 #include "chrome/browser/ui/sync/browser_synced_window_delegate.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "chrome/browser/sessions/session_id.h" 9 #include "chrome/browser/sessions/session_id.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
11 #include "chrome/browser/ui/browser_finder.h" 11 #include "chrome/browser/ui/browser_finder.h"
12 #include "chrome/browser/ui/browser_list.h" 12 #include "chrome/browser/ui/browser_iterator.h"
13 #include "chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h" 13 #include "chrome/browser/ui/sync/tab_contents_synced_tab_delegate.h"
14 #include "chrome/browser/ui/tabs/tab_strip_model.h" 14 #include "chrome/browser/ui/tabs/tab_strip_model.h"
15 15
16 // static SyncedWindowDelegate implementations 16 // static SyncedWindowDelegate implementations
17 17
18 // static 18 // static
19 const std::set<browser_sync::SyncedWindowDelegate*> 19 const std::set<browser_sync::SyncedWindowDelegate*>
20 browser_sync::SyncedWindowDelegate::GetSyncedWindowDelegates() { 20 browser_sync::SyncedWindowDelegate::GetSyncedWindowDelegates() {
21 std::set<browser_sync::SyncedWindowDelegate*> synced_window_delegates; 21 std::set<browser_sync::SyncedWindowDelegate*> synced_window_delegates;
22 for (BrowserList::const_iterator i = BrowserList::begin(); 22 for (chrome::BrowserIterator it; !it.done(); it.Next())
23 i != BrowserList::end(); ++i) { 23 synced_window_delegates.insert(it->synced_window_delegate());
24 synced_window_delegates.insert((*i)->synced_window_delegate());
25 }
26 return synced_window_delegates; 24 return synced_window_delegates;
27 } 25 }
28 26
29 // static 27 // static
30 const browser_sync::SyncedWindowDelegate* 28 const browser_sync::SyncedWindowDelegate*
31 browser_sync::SyncedWindowDelegate::FindSyncedWindowDelegateWithId( 29 browser_sync::SyncedWindowDelegate::FindSyncedWindowDelegateWithId(
32 SessionID::id_type id) { 30 SessionID::id_type id) {
33 Browser* browser = chrome::FindBrowserWithID(id); 31 Browser* browser = chrome::FindBrowserWithID(id);
34 // In case we don't find the browser (e.g. for Developer Tools). 32 // In case we don't find the browser (e.g. for Developer Tools).
35 return browser ? browser->synced_window_delegate() : NULL; 33 return browser ? browser->synced_window_delegate() : NULL;
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 return browser_->is_type_tabbed(); 85 return browser_->is_type_tabbed();
88 } 86 }
89 87
90 bool BrowserSyncedWindowDelegate::IsTypePopup() const { 88 bool BrowserSyncedWindowDelegate::IsTypePopup() const {
91 return browser_->is_type_popup(); 89 return browser_->is_type_popup();
92 } 90 }
93 91
94 bool BrowserSyncedWindowDelegate::IsSessionRestoreInProgress() const { 92 bool BrowserSyncedWindowDelegate::IsSessionRestoreInProgress() const {
95 return false; 93 return false;
96 } 94 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser_list.h ('k') | chrome/browser/ui/tabs/pinned_tab_codec.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698