chrome/browser/custom_home_pages_table_model.cc - Issue 12114034: Swap BrowserList::const_iterator for the multi-desktop aware BrowserIterator in many scenarios.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/custom_home_pages_table_model.cc

Issue 12114034: Swap BrowserList::const_iterator for the multi-desktop aware BrowserIterator in many scenarios. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/automation/testing_automation_provider.cc ('k') | chrome/browser/devtools/browser_list_tabcontents_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/custom_home_pages_table_model.cc

diff --git a/chrome/browser/custom_home_pages_table_model.cc b/chrome/browser/custom_home_pages_table_model.cc

index af8e86b2d1969c5a67ba6f87f1290f959e47ee91..fca0a06a1385c4335552b2511b4641e14da916a1 100644

--- a/chrome/browser/custom_home_pages_table_model.cc

+++ b/chrome/browser/custom_home_pages_table_model.cc

@@ -12,6 +12,7 @@

#include "chrome/browser/prefs/pref_service.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

+#include "chrome/browser/ui/browser_iterator.h"

#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/common/pref_names.h"

@@ -179,9 +180,8 @@ void CustomHomePagesTableModel::SetToCurrentlyOpenPages() {

// And add all tabs for all open browsers with our profile.

int add_index = 0;

- for (BrowserList::const_iterator browser_i = BrowserList::begin();

- browser_i != BrowserList::end(); ++browser_i) {

- Browser* browser = *browser_i;

+ for (chrome::BrowserIterator it; !it.done(); it.Next()) {

+ Browser* browser = *it;

if (browser->profile() != profile_)

continue; // Skip incognito browsers.