chrome/browser/performance_monitor/performance_monitor.cc - Issue 12114034: Swap BrowserList::const_iterator for the multi-desktop aware BrowserIterator in many scenarios.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/performance_monitor/performance_monitor.cc

Issue 12114034: Swap BrowserList::const_iterator for the multi-desktop aware BrowserIterator in many scenarios. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/performance_monitor/performance_monitor.cc

diff --git a/chrome/browser/performance_monitor/performance_monitor.cc b/chrome/browser/performance_monitor/performance_monitor.cc

index 66de415383a1de1ae91ffe66f70c51b0ad44ab52..deff1a04f629f75d8b3854056e3aa0ce5754c965 100644

--- a/chrome/browser/performance_monitor/performance_monitor.cc

+++ b/chrome/browser/performance_monitor/performance_monitor.cc

@@ -23,7 +23,7 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_manager.h"

#include "chrome/browser/ui/browser.h"

-#include "chrome/browser/ui/browser_list.h"

+#include "chrome/browser/ui/browser_iterator.h"

#include "chrome/common/chrome_notification_types.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/chrome_version_info.h"

@@ -398,10 +398,8 @@ void PerformanceMonitor::UpdateLiveProfiles() {

scoped_ptr<std::set<std::string> > active_profiles(

new std::set<std::string>());

- for (BrowserList::const_iterator iter = BrowserList::begin();

- iter != BrowserList::end(); ++iter) {

- active_profiles->insert((*iter)->profile()->GetDebugName());

- }

+ for (chrome::BrowserIterator it; !it.done(); it.Next())

+ active_profiles->insert(it->profile()->GetDebugName());

BrowserThread::PostBlockingPoolSequencedTask(

Database::kDatabaseSequenceToken,

« no previous file with comments | « chrome/browser/managed_mode/managed_mode.cc ('k') | chrome/browser/sessions/session_service.cc » ('j') | no next file with comments »