[Telemetry] Clean separation between tab (public API) and tab_backend (Chrome implementation). Flat…

[Telemetry] Clean separation between tab (public API) and tab_backend (Chrome implementation). Flatten tab's public methods.

E.g. instead of tab.page.Navigate('url') it's now tab.Navigate('url'). This makes more sense for other browsers, who won't have the same domain divisions that Chrome DevTools does; and paves the way for future organization/separation between public API and backends.


BUG=None.
TEST=None.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177087

[dtu, 2013-01-09 00:57:06]

How does this look? Before I go about renaming all tab invocations in all of
telemetry and perf.

[nduca, 2013-01-09 01:02:29]

lgtm with tweaks

https://codereview.chromium.org/11819018/diff/1/tools/telemetry/telemetry/tab.py
File tools/telemetry/telemetry/tab.py (right):

https://codereview.chromium.org/11819018/diff/1/tools/telemetry/telemetry/tab...
tools/telemetry/telemetry/tab.py:21: self._backend = tab_backend.TabBackend(
Is there a way to pass in the tab_backend on the constructor, and have it be
vended by the browser_backend?

https://codereview.chromium.org/11819018/diff/1/tools/telemetry/telemetry/tab...
tools/telemetry/telemetry/tab.py:78: """Executes action_function, and waits for
the navigation to complete.
what is the type of action_function? Lets make sure we explain that its a python
function, so people dont go passing in javascript

https://codereview.chromium.org/11819018/diff/1/tools/telemetry/telemetry/tab...
tools/telemetry/telemetry/tab.py:93: def Execute(self, expr,
timeout=DEFAULT_TAB_TIMEOUT):
ExecuteJavascript

https://codereview.chromium.org/11819018/diff/1/tools/telemetry/telemetry/tab...
tools/telemetry/telemetry/tab.py:100: def Evaluate(self, expr,
timeout=DEFAULT_TAB_TIMEOUT):
EvaluateJavascript

https://codereview.chromium.org/11819018/diff/1/tools/telemetry/telemetry/tab...
tools/telemetry/telemetry/tab.py:118: def StartRecording(self):
StartRecording what?

[dtu, 2013-01-09 01:21:27]

https://codereview.chromium.org/11819018/diff/1/tools/telemetry/telemetry/tab.py
File tools/telemetry/telemetry/tab.py (right):

https://codereview.chromium.org/11819018/diff/1/tools/telemetry/telemetry/tab...
tools/telemetry/telemetry/tab.py:21: self._backend = tab_backend.TabBackend(
On 2013/01/09 01:02:30, nduca wrote:
> Is there a way to pass in the tab_backend on the constructor, and have it be
> vended by the browser_backend?

Done.

https://codereview.chromium.org/11819018/diff/1/tools/telemetry/telemetry/tab...
tools/telemetry/telemetry/tab.py:78: """Executes action_function, and waits for
the navigation to complete.
On 2013/01/09 01:02:30, nduca wrote:
> what is the type of action_function? Lets make sure we explain that its a
python
> function, so people dont go passing in javascript

Done.

https://codereview.chromium.org/11819018/diff/1/tools/telemetry/telemetry/tab...
tools/telemetry/telemetry/tab.py:93: def Execute(self, expr,
timeout=DEFAULT_TAB_TIMEOUT):
On 2013/01/09 01:02:30, nduca wrote:
> ExecuteJavascript

Done.

https://codereview.chromium.org/11819018/diff/1/tools/telemetry/telemetry/tab...
tools/telemetry/telemetry/tab.py:100: def Evaluate(self, expr,
timeout=DEFAULT_TAB_TIMEOUT):
On 2013/01/09 01:02:30, nduca wrote:
> EvaluateJavascript

Done.

https://codereview.chromium.org/11819018/diff/1/tools/telemetry/telemetry/tab...
tools/telemetry/telemetry/tab.py:118: def StartRecording(self):
On 2013/01/09 01:02:30, nduca wrote:
> StartRecording what?

StartTimelineRecording? StartEventRecording? I don't think this method will have
corresponding concepts in other browsers.

[nduca, 2013-01-09 01:35:11]

I'm fine with either

[nduca, 2013-01-09 01:35:24]

I lie. Get timeline in there.

[dtu, 2013-01-12 00:05:35]

On 2013/01/09 01:35:24, nduca wrote:
> I lie. Get timeline in there.

I'm gonna split the patch up in order to land it, since it affects pretty much
every file in telemetry and perf. How about temporarily adding methods to tab to
access the existing tab.console/page/etc, then removing them one at a time?

[nduca, 2013-01-12 00:07:05]

Thats fine!

[nduca, 2013-01-15 05:29:51]

How we doing here?

[tab_backend should probably get renamed to be something that could be used by
both tabs and extensions, per https://codereview.chromium.org/11882033/. Not
sure the name myself.]

[agable, 2013-01-16 21:40:57]

This change has been reverted by
http://src.chromium.org/viewvc/chrome?view=rev&revision=177225. See bug at
https://code.google.com/p/chromium/issues/detail?id=170310.